-
Notifications
You must be signed in to change notification settings - Fork 46
Add variants to jobs #1008
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add variants to jobs #1008
Conversation
Adds variants to the staging jobs. Only applies to staging, and uses a branch to avoid early public availability.
⏱️ 11m total CI duration on this PR
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You'll probably also want to wire in changing places where JEST_JUNIT_SUITE_NAME
is set, otherwise the variants will only show up under different tests still
I'm not sure I understand this? Why does that matter, and what do you mean by show up under different tests? |
Big fan of variants and I want to get it set up here. Right now we set So if the desire of this change is for this to show up as one |
I see, will do. You're correct that it'll create a new test, but adding a variant does that anyway, so that's already a thing. |
@TylerJang27 Ah, gotcha. Since we're only testing this on staging, and the uploader runs for the same tests on both staging and prod, I'd prefer to leave it as-is to not mess with prod for now, if that's alright? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sounds good, that's fine by me
Adds variants to the staging jobs. Only applies to staging, and uses a branch to avoid early public availability.