New linter yamlfmt #1011
Open
New linter yamlfmt #1011
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
⏱️ 13m total CI duration on this PR
|
det
reviewed
Apr 16, 2025
linters/yamlfmt/.yamlfmt.yaml
Outdated
| @@ -0,0 +1,9 @@ | |||
| exclude: | |||
There was a problem hiding this comment.
Some notes:
- I'm not sure it makes sense to exclude
trunk.yamlby default - We already ignore lock files for all formaters
- We generally accept the defaults for each tool instead of being opinionated about style. The exception would be defaults to help the tool fit into the
trunkecosystem (ie, disable all formatting rules in a linter because we expect a user to run a separate formatter).
I would suggest deleting this file.
There was a problem hiding this comment.
Not ignoring trunk.yaml makes that this file will be reported always after trunk upgrade or other operations. I think it would be more safe to exclude it.
Other settings are more sane than the default which basically massacres YAML files by ie. removing empty lines. It would be better to leave it to improve the user experience.
If it doesn't convince you I can remove the config file. It would be just better to not enable the plugin by default if any YAML file exists.
|
@det Do we miss anything else? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a configuration for https://github.com/google/yamlfmt which is the fast YAML formatter that works with different settings, ie. can format arrays with Kubernetes-style (without indentation).