Skip to content

(Chore): Various repo cleanup and support quarantining #905

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Nov 13, 2024
Merged

(Chore): Various repo cleanup and support quarantining #905

merged 6 commits into from
Nov 13, 2024
+17 −20

Conversation

TylerJang27
Copy link
Collaborator

@TylerJang27 TylerJang27 commented Nov 5, 2024 •
edited
Loading

Clean up some old todos and change the nightly+weekly cadences slightly to hopefully be less flaky. Also adds the setup needed to support quarantining

Successful run verifying intended functionality

@trunk-io Trunk.io
Copy link

trunk-io bot commented Nov 5, 2024 •
edited
Loading

⏱️ 2h 24m total CI duration on this PR
Job Cumulative Duration Recent Runs
Windows Linter Tests 1h 2m 🟩 
Linter Tests macOS 38m 🟥 🟥 
Linter Tests ubuntu-latest 21m 🟥 
Tool Tests (macOS) 10m 🟩 
Tool Tests (ubuntu-latest) 8m 🟥 
Action Tests 1m 🟩 
Trunk Check runner [linux] 1m 🟩 
CodeQL-Build 1m 🟩 
Repo Tests / Plugin Tests 31s 🟩 
Detect changed files 4s 🟩 
Aggregate Test Results 3s 🟥 

settings ⋅ feedback ⋅ docs ⋅ learn more about trunk.io

@TylerJang27 TylerJang27 changed the title ( (Chore): Various repo cleanup and support quarantining Nov 5, 2024
@trunk-staging-io Trunk-Staging.io
Copy link

trunk-staging-io bot commented Nov 5, 2024 •
edited
Loading

75 tests were run on b2a77c02. ⏭️ 2 Skipped. View Full Report ↗︎

⏭️ 2 Skipped
  • Testing tool kubectl kubectl version --short
  • Testing action hello-world-python action

settings

@TylerJang27 TylerJang27 marked this pull request as ready for review November 12, 2024 22:03
@TylerJang27
Copy link
Collaborator Author

Going to revert the buf change, I think there may be a version issue

@trunk-io Trunk.io
Copy link

trunk-io bot commented Nov 12, 2024 •
edited
Loading

264 tests were run on b2a77c02. ⚠️ 1 Flaked, ⏭️ 8 Skipped. View Full Report ↗︎

⚠️ 1 Flakes
Test Name Failure Summary Logs
Testing linter trivy test fs-vuln Logs ↗︎
⏭️ 8 Skipped
  • Testing linter stringslint test CUSTOM
  • Testing formatter swiftformat test basic
  • Testing linter terrascan test basic
  • Testing linter terrascan test aws$1db$1instance$1violation
  • Testing linter swiftlint test basic

... and 3 more

settings

@TylerJang27 TylerJang27 enabled auto-merge (squash) November 12, 2024 23:19
@TylerJang27 TylerJang27 disabled auto-merge November 13, 2024 08:34
@TylerJang27 TylerJang27 enabled auto-merge (squash) November 13, 2024 08:34
@TylerJang27 TylerJang27 disabled auto-merge November 13, 2024 08:35
@TylerJang27 TylerJang27 merged commit cf4a9c5 into main Nov 13, 2024
13 of 15 checks passed
@TylerJang27 TylerJang27 deleted the tyler/repo-cleanup branch November 13, 2024 08:35
@trunk-staging-io Trunk-Staging.io
Copy link

It seems like this PR has failing tests. I will investigate the failures and provide a report.

View trace in langsmith

@trunk-staging-io Trunk-Staging.io
Copy link

Summary

The tests are failing, and the author is trying to prevent the CI from failing by using continue-on-error: true and quarantine: true.

Root Cause Analysis

The changes in the action.yaml files add continue-on-error: true and replace continue-on-error: true with quarantine: true. This indicates that the author is aware of the test failures and is trying to prevent them from failing the CI. However, this will not fix the underlying issue. The author should investigate the root cause of the test failures and fix them.

Resolution Plan

  1. Remove continue-on-error: true and quarantine: true from the action.yaml files.
  2. Investigate the root cause of the test failures.
  3. Fix the test failures.
  4. Re-run the tests to ensure that they pass.

View trace in langsmith

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@det det det approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@TylerJang27 @det