Skip to content

Update ruby-build version to latest #919

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 5, 2024
Merged

Update ruby-build version to latest #919

merged 1 commit into from
Dec 5, 2024

Conversation

amkisko
Copy link
Contributor

@amkisko amkisko commented Nov 18, 2024

No description provided.

@trunk-io Trunk.io
Copy link

trunk-io bot commented Nov 18, 2024 •
edited
Loading

⏱️ 1h 30m total CI duration on this PR
Job Cumulative Duration Recent Runs
Linter Tests macOS 54m 🟩 
Linter Tests ubuntu-latest 20m 🟩 
Tool Tests (ubuntu-latest) 7m 🟩 
Tool Tests (macOS) 5m 🟩 
Action Tests 1m 🟩 
CodeQL-Build 1m 🟩 
Trunk Check runner [linux] 1m 🟩 
Detect changed files 10s 🟩 
Aggregate Test Results 1s 🟩 

settings ⋅ feedback ⋅ docs ⋅ learn more about trunk.io

@amkisko
Copy link
Contributor Author

amkisko commented Nov 18, 2024 •
edited
Loading

As additional question: how to patch runtime definition within project configuration? So let's say we would like to have completely custom ruby-build version and download path.

If I follow this https://docs.trunk.io/cli/configuration/runtimes, it should be enough to go with:

runtimes:
  definitions:
    - type: ruby
    ...

@amkisko
Copy link
Contributor Author

amkisko commented Nov 18, 2024 •
edited
Loading

It could be nice to mention this feature in documentation.

Final working version:

downloads:
  - name: custom-ruby-build
    version: 20241105
    downloads:
      - os:
          linux: linux
          macos: macos
        url: https://github.com/rbenv/ruby-build/archive/refs/tags/v20241105.tar.gz
        strip_components: 1
runtimes:
  enabled:
    - ruby@3.1.4
  definitions:
    - type: ruby
      download: custom-ruby-build

det
det approved these changes Nov 20, 2024
View reviewed changes
Copy link
Contributor

@det det left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution!

@det det merged commit c93185f into trunk-io:main Dec 5, 2024
14 checks passed
@amkisko amkisko deleted the patch-1 branch December 6, 2024 06:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@det det det approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@amkisko @det