fix(infinite-loop): Rebased commit gets a different sha1 #11
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a commit is rebased, git create a new sha1, but github keep a reference to the old one (see
GET /repos/:owner/:repo/commits).When starting github-changelog by using a rebased commit as limit, the module enter in an infinite loop, because it keeps calling the
pageOfCommitsfunction until it find the limiting sha1 (the old one, not existing anymore in the commits list).This fix is just a work around and does not really solve this issue. Github is smart enough to stop returning commits when the limiting sha1 or his alias is reached.