Skip to content

ci: publish common gh outputs during release #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

haritowa
Copy link

@haritowa haritowa commented Mar 9, 2023

This PR introduce change which publishes gh outputs during release if --github option is provided:

  • current_version
  • current_release_version
  • new_version
  • should_bump

The changes are tested via tmp branch in my repo.

@tumayt tumayt self-requested a review March 9, 2023 21:19
Copy link
Owner

@tumayt tumayt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is already implemented for cli command "semantic-release github". Please use it if you wish to recieve information without publish. On the otherhand cli command "semantic-release publish --github" will output published version and flag.
Can you clarify your case ?
Also plase see this example which checks and publishes new version. Based on the output of publish also docker image is published and new version documentation is built.

@haritowa
Copy link
Author

haritowa commented Mar 9, 2023

Hello. I don't want to receive information that has not been published. I need a way to retrieve the most recent version, whether it has been published or not, after the publishing process has taken place(or not).

The current implementation only outputs published versions if there is a new one. Additionally, the action.yml does not provide a way to call the github command.

One solution might be to run both commands during the action.yml run. However, why not use the already existing variables and publish them during the release command?

Another solution is to create a separate action that will call the github command. However, this is repetitive, requires supporting another action/repo, and could lead to double the action docker build time (not sure here).

My pull request does not introduce anything new. It uses already defined variables and publishes already defined outputs. Hope this clarifies my use case and the problem I am trying to fix

@haritowa haritowa requested a review from tumayt March 9, 2023 22:58
Copy link
Owner

@tumayt tumayt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe you have already talked with @aasseman to resolve this with another way and he explained me about your aim. Please see this action which is very similiar what you want to achieve (get version without publish).

@haritowa
Copy link
Author

Yeah we did. I'll close the PR then

@haritowa haritowa closed this Mar 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants