Next gen examples #310
Merged
Next gen examples #310
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jingming
reviewed
Feb 27, 2017
twilio/jwt/validation/__init__.py
Outdated
|
|
||
| if headers_str: | ||
| signed_payload.append(headers_str) | ||
| signed_payload.append('') |
There was a problem hiding this comment.
This branch includes the next-gen-client-validation branch. In this case its necessary to append nothing because signed_payload is a list which we eventually join with '\n' so we need to add the extra empty line.
jingming
reviewed
Feb 27, 2017
examples/basic_usage.py
Outdated
|
|
||
| print('Get only last 10 messages...') | ||
| some_messages = client.messages.list(limit=10) | ||
|
|
There was a problem hiding this comment.
Should we have prints for all the example requests?
There was a problem hiding this comment.
I can replace with comments if youd prefer?
|
👍 |
a4bce18 to
1212966
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.