add request logging and hooking #385
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
codejudas
reviewed
Aug 21, 2017
twilio/http/http_client.py
Outdated
| try: | ||
| from urllib.parse import urlencode | ||
| except ImportError: | ||
| from urllib import urlencode |
There was a problem hiding this comment.
you should import things via the compat.py module which handles version specific imports like this for you.
|
pushed commit to change urlencode import from twilio.compat |
|
@tysonholub Thank you for your PR! We have made a ticket in our internal tracking system and will get to this as soon as we can. |
dougblack
reviewed
Oct 16, 2017
twilio/http/http_client.py
Outdated
| @@ -47,4 +72,12 @@ def request(self, method, url, params=None, data=None, headers=None, auth=None, | |||
| timeout=timeout, | |||
| ) | |||
|
|
|||
| if hasattr(response, 'json') and response.json(): | |||
| # strip JSON of possible prettyprint | |||
There was a problem hiding this comment.
The API doesn't pretty print. We probably want to save the loads/dumps cost by just always using response.text.
dougblack
reviewed
Oct 16, 2017
twilio/http/http_client.py
Outdated
| @@ -38,7 +45,25 @@ def request(self, method, url, params=None, data=None, headers=None, auth=None, | |||
| session = Session() | |||
| session.verify = get_cert_file() | |||
|
|
|||
| request = Request(method.upper(), url, params=params, data=data, headers=headers, auth=auth) | |||
| kwargs = dict( | |||
There was a problem hiding this comment.
nit: Let's just use a dict literal here.
|
I should be able to address these issues before Friday. Thanks! |
dougblack
approved these changes
Oct 19, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR adds request/response logging and request hooks to TwilioHttpClient