Skip to content

update request validator to remove port numbers from https urls #394

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 20, 2017
Merged

update request validator to remove port numbers from https urls #394

merged 2 commits into from
Oct 20, 2017

Conversation

Brodan
Copy link
Contributor

@Brodan Brodan commented Oct 7, 2017

this pull request is to address issue #392

@Brodan Brodan mentioned this pull request Oct 7, 2017
Closed
thomasst
thomasst reviewed Oct 8, 2017
View reviewed changes
twilio/request_validator.py Outdated
@@ -24,6 +24,19 @@ def compare(string1, string2):
return result


def reomve_port(uri):
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Typo

@Brodan
Copy link
Contributor Author

Brodan commented Oct 15, 2017

@jingming is anyone able to look at this?

codejudas
codejudas approved these changes Oct 17, 2017
View reviewed changes
Copy link
Contributor

@codejudas codejudas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 @Brodan Thanks for the contribution!

@codejudas codejudas merged commit 9f3a32f into twilio:master Oct 20, 2017
@Brodan Brodan deleted the https_validation_fix branch October 20, 2017 19:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
2 more reviewers

@thomasst thomasst thomasst left review comments

@codejudas codejudas codejudas approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Brodan @thomasst @codejudas