Remove readonly keyword from the state #600
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Based on this [PR](DefinitelyTyped/DefinitelyTyped#26813) we don't have to put `readonly` for our states, because `React.Component<P,S>` already marks them as immutable.
eps1lon
requested changes
Jan 7, 2023
There was a problem hiding this comment.
Seems to me, it's still beneficial to add readonly:
class Provider extends React.Component<
{ children?: React.ReactNode },
ProviderState
> {
public state = {
themeColor: "red",
}
render() {
// should TS error but doesn't :(
this.state = {themeColor: 'blue'}
return null
}
}|
Closing, since the context page has been reworked and does no longer include a class-based version. Feel free to comment on the new context page! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on this PR we don't have to put
readonlyfor our states, becauseReact.Component<P,S>already marks them as immutable.