Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: typescript-eslint/typescript-eslint
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: v1.4.0
Choose a base ref
...
head repository: typescript-eslint/typescript-eslint
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: v1.4.1
Choose a head ref
  • 8 commits
  • 194 files changed
  • 6 contributors

Commits on Feb 19, 2019

  1. chore(*): Enable comma-dangle (#271)

    As per the discussion on slack.
    Enable `comma-dangle` eslint rule + prettier config.
    Good for two reasons:
    1) (the main reason) It will create less noise in PRs:
    ```diff
     {
    -  "foo": true
    +  "foo": true,
    +  "bar": false
     }
    ```
    2) It makes reordering members easier because there is always a comma at the end.
    
    ----
    
    Steps to create this PR:
    1) add line in eslint config
    2) add prettier config
    3) run `yarn format`
    4) ???
    5) profit.
    
    No other code was manually touched in the making of this PR.
    bradzacher authored Feb 19, 2019
    Configuration menu
    Copy the full SHA
    1d9ca84 View commit details
    Browse the repository at this point in the history
  2. test(ts-estree): add missing test cases (#300)

    * refactor(ts-estree): improve types in convertBodyExpressions
    
    * refactor(ts-estree): change FirstTypeNode to TypePredicate
    
    * test(ts-estree): add missing test cases
    
    * chore(ts-estree): disable coverage for Debug.fail
    
    * refactor(ts-estree): make sure that BindingElement is always converted
    armano2 authored Feb 19, 2019
    Configuration menu
    Copy the full SHA
    1b3d31e View commit details
    Browse the repository at this point in the history

Commits on Feb 23, 2019

  1. Configuration menu
    Copy the full SHA
    b29cad9 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    4526f27 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    0635183 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    9a88363 View commit details
    Browse the repository at this point in the history
  5. chore: publish v1.4.1

    JamesHenry committed Feb 23, 2019
    Configuration menu
    Copy the full SHA
    d362c4a View commit details
    Browse the repository at this point in the history
Loading