chore(*): Enable comma-dangle #271
Conversation
| @@ -7,6 +7,7 @@ | |||
| }, | |||
| "extends": ["eslint:recommended", "plugin:@typescript-eslint/recommended"], | |||
| "rules": { | |||
| "comma-dangle": ["error", "always-multiline"], | |||
There was a problem hiding this comment.
do we need eslint rule for this? we are using prettier
There was a problem hiding this comment.
the lint rule gives you in-editor warnings when you're writing code (helps in case you don't have format on save turned on).
will also give a better warning in the CI logs. (the prettier check will just say the file failed formatting, whereas the eslint check will tell you the actual problem)
|
i'm unsure if i like this Pros:
Cons:
i don't have strong opinion on code style |
I write objects in one line and let Prettier format things for me! |
|
Pros:
It's covered by eslint fixers and by prettier.
|
This comment has been minimized.
This comment has been minimized.
# Conflicts: # packages/eslint-plugin/src/rules/prefer-namespace-keyword.ts # packages/eslint-plugin/tests/rules/promise-function-async.test.ts # packages/typescript-estree/src/convert.ts # packages/typescript-estree/src/node-utils.ts # tests/integration/utils/generate-package-json.js
As per the discussion on slack.
Enable
comma-dangleeslint rule + prettier config.Good for two reasons:
{ - "foo": true + "foo": true, + "bar": false }Steps to create this PR:
yarn formatNo other code was manually touched in the making of this PR.