-
-
Notifications
You must be signed in to change notification settings - Fork 2.8k
Comparing changes
Open a pull request
base repository: typescript-eslint/typescript-eslint
base: v3.10.1
head repository: typescript-eslint/typescript-eslint
compare: v4.0.0
- 18 commits
- 164 files changed
- 4 contributors
Commits on Aug 27, 2020
-
Configuration menu - View commit details
-
Copy full SHA for a10d671 - Browse repository at this point
Copy the full SHA a10d671View commit details
Commits on Aug 29, 2020
-
Configuration menu - View commit details
-
Copy full SHA for 3854d6c - Browse repository at this point
Copy the full SHA 3854d6cView commit details -
Configuration menu - View commit details
-
Copy full SHA for e9d2ab6 - Browse repository at this point
Copy the full SHA e9d2ab6View commit details -
Configuration menu - View commit details
-
Copy full SHA for 3be125d - Browse repository at this point
Copy the full SHA 3be125dView commit details -
Configuration menu - View commit details
-
Copy full SHA for c70f54f - Browse repository at this point
Copy the full SHA c70f54fView commit details -
feat(eslint-plugin): [ban-ts-comment] change default for `ts-expect-e…
Configuration menu - View commit details
-
Copy full SHA for a3f163a - Browse repository at this point
Copy the full SHA a3f163aView commit details -
Configuration menu - View commit details
-
Copy full SHA for a9cd6fb - Browse repository at this point
Copy the full SHA a9cd6fbView commit details -
Configuration menu - View commit details
-
Copy full SHA for 9de669f - Browse repository at this point
Copy the full SHA 9de669fView commit details -
fix: correct decorator traversal for AssignmentPattern (#2375)
BREAKING CHANGE: - Removed decorators property from several Nodes that could never semantically have them (FunctionDeclaration, TSEnumDeclaration, and TSInterfaceDeclaration) - Removed AST_NODE_TYPES.Import. This is a minor breaking change as the node type that used this was removed ages ago.
Configuration menu - View commit details
-
Copy full SHA for d738fa4 - Browse repository at this point
Copy the full SHA d738fa4View commit details -
fix(typescript-estree): correct ChainExpression interaction with pare…
…ntheses and non-nulls (#2380)
Configuration menu - View commit details
-
Copy full SHA for 762bc99 - Browse repository at this point
Copy the full SHA 762bc99View commit details -
Configuration menu - View commit details
-
Copy full SHA for 58b1c2d - Browse repository at this point
Copy the full SHA 58b1c2dView commit details -
feat(eslint-plugin): [no-unnecessary-condition][strict-boolean-expres…
…sions] add option to make the rules error on files without `strictNullChecks` turned on (#2345)
Configuration menu - View commit details
-
Copy full SHA for 9273441 - Browse repository at this point
Copy the full SHA 9273441View commit details -
feat(typescript-estree): switch to globby (#2418)
Fixes #2398 If the user has a particularly large node_modules folder and uses globs for `parserOption.project`, then the `glob` library can spend a decent chunk of time searching the `node_modules` folder. In some cases, this can be on the order of hundreds to thousands of milliseconds. This wouldn't be a problem, but for safety and correctness during a persistent parse, we have to do this check for every call to the parser (i.e. every file that's being linted). Over a whole project, this can easily add up to many, many seconds wasted. Previously, we: - applied the project globs, one by one - then manually excluded `tsconfig`s from the list. This meant that we are always slow. I remember I did this because I had issues getting `glob`'s `ignore` option to work at all. ## The solution `globby` is a better glob library: - it accepts an array of globs, which saves us doing manual looping - it supports exclusion globs (globs prefixed with `!`), which are evaluated as part of the glob process - it has caching built in by default This allows us to evaluate all of the `project` globs at once, as opposed to one at a time (so should be less duplicated work). This also allows us to evaluate the `projectFolderIgnoreList` at the same time as the `project` globs (so should be no useless work done). All of these together should cut the glob evaluation time down to ~50ms for the first parse, and ~2ms for each parse after that (due to caching). For comparison, previously, in bad cases we would spend ~3-500ms, per project, per parsed file. Example to illustrate how much faster this can potentially be: For a project that provides 2 globs and has 100 files. Before: 300ms * 2 * 100 = 60,000ms (60s) After: 50ms + 2 * 100 = 250ms This should also save a non-trival amount of time in other, more optimal setups. BREAKING CHANGE: - removes the ability to supply a `RegExp` to `projectFolderIgnoreList`, and changes the meaning of the string value from a regex to a glob.
Configuration menu - View commit details
-
Copy full SHA for 3a7ec9b - Browse repository at this point
Copy the full SHA 3a7ec9bView commit details -
Configuration menu - View commit details
-
Copy full SHA for cd84549 - Browse repository at this point
Copy the full SHA cd84549View commit details -
Configuration menu - View commit details
-
Copy full SHA for ac0defc - Browse repository at this point
Copy the full SHA ac0defcView commit details -
Configuration menu - View commit details
-
Copy full SHA for c3a6c2a - Browse repository at this point
Copy the full SHA c3a6c2aView commit details -
Configuration menu - View commit details
-
Copy full SHA for 4ff8c43 - Browse repository at this point
Copy the full SHA 4ff8c43View commit details
Commits on Aug 31, 2020
-
Configuration menu - View commit details
-
Copy full SHA for c51e3f0 - Browse repository at this point
Copy the full SHA c51e3f0View commit details
This comparison is taking too long to generate.
Unfortunately it looks like we can’t render this comparison for you right now. It might be too big, or there might be something weird with your repository.
You can try running this command locally to see the comparison on your machine:
git diff v3.10.1...v4.0.0