Skip to content

Using / as config name separator. #10181

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
ntnyq opened this issue Oct 20, 2024 · 3 comments
Closed

Using / as config name separator. #10181

ntnyq opened this issue Oct 20, 2024 · 3 comments
Labels
locked due to age Please open a new issue if you'd like to say more. See https://typescript-eslint.io/contributing. package: typescript-eslint Issues related to the typescript-eslint package wontfix This will not be worked on

Comments

@ntnyq
Copy link
Contributor

ntnyq commented Oct 20, 2024 •
edited
Loading

ESLint officially recommended using / as the config name separator.

Refs:

ESLint docs - configuration-naming-conventions

In #10094, config names are joined with __.

Maybe we should change it to /.
@ntnyq ntnyq changed the title Oh, TIL. Yes that'd probably be good - up for filing an issue @ntnyq? 🙂 Using / as config name separator. Oct 20, 2024
@bradzacher
Copy link
Member

Part of me thinks that __ is better than / for our "generated" name because it avoids clashes and makes it clearer that the name was joined by us automatically.

@auvred
Copy link
Member

auvred commented Oct 21, 2024

I thought about using / when I was working on #10094, but I decided to stick with __. Because / refers to scopes for shared configurations/plugins, and tseslint.config is just an utility function that applies some common options to a several extended configs. It doesn't actually configure anything. So I'm +1 on using __ here.

@JoshuaKGoldberg
Copy link
Member

Looks like we have consensus on __. I'm in favor of making it more clearly generated. Thanks all!

@JoshuaKGoldberg JoshuaKGoldberg closed this as not planned Won't fix, can't repro, duplicate, stale Nov 4, 2024
@JoshuaKGoldberg JoshuaKGoldberg added wontfix This will not be worked on package: typescript-eslint Issues related to the typescript-eslint package labels Nov 4, 2024
@github-actions github-actions bot added the locked due to age Please open a new issue if you'd like to say more. See https://typescript-eslint.io/contributing. label Nov 12, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 12, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
locked due to age Please open a new issue if you'd like to say more. See https://typescript-eslint.io/contributing. package: typescript-eslint Issues related to the typescript-eslint package wontfix This will not be worked on
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@JoshuaKGoldberg @bradzacher @ntnyq @auvred