Skip to content

Bug: [no-misused-promises] bad report loc for methods in object literals #10212

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
4 tasks done
kirkwaiblinger opened this issue Oct 26, 2024 · 2 comments · Fixed by #10216
Closed
4 tasks done

Bug: [no-misused-promises] bad report loc for methods in object literals #10212

kirkwaiblinger opened this issue Oct 26, 2024 · 2 comments · Fixed by #10216
Labels
accepting prs Go ahead, send a pull request that resolves this issue bug Something isn't working locked due to age Please open a new issue if you'd like to say more. See https://typescript-eslint.io/contributing. package: eslint-plugin Issues related to @typescript-eslint/eslint-plugin

Comments

@kirkwaiblinger
Copy link
Member

kirkwaiblinger commented Oct 26, 2024

Before You File a Bug Report Please Confirm You Have Done The Following...

  • I have tried restarting my IDE and the issue persists.
  • I have updated to the latest version of the packages.
  • I have searched for related issues and found none that matched my issue.
  • I have read the FAQ and my problem is not listed.

Playground Link

https://typescript-eslint.io/play/#ts=5.6.2&showAST=ts&fileType=.ts&code=C4TwDgpgBAEghgZwGoHsCWATAshYALFDKAXigG8AoKKAMwAoBKALigDd0MKBfCigYxQA7BMCgoW8ZBxz5CJclSiIQgvrUbkoPLkA&eslintrc=N4KABGBEBOCuA2BTAzpAXGUEKQAIBcBPABxQGNoBLY-AWhXkoDt8B6Jge1oFtLlZkiACa1i0Dr0GoMkAO4BDaE0jgwAXxBqgA&tsconfig=N4KABGBEDGD2C2AHAlgGwKYCcDyiAuysAdgM6QBcYoEEkJemy0eAcgK6qoDCAFutAGsylBm3TgwAXxCSgA&tokens=false

Repro Code

type HasVoidMethod = {
  f(): void
}

const o: HasVoidMethod = {
  async f() { }
}

ESLint Config

module.exports = {
  "rules": {
    "@typescript-eslint/no-misused-promises": "warn"
  }
}

tsconfig

{
  "compilerOptions": {
    "strictNullChecks": true
  }
}

Expected Result

const o: HasVoidMethod = {
  async f() { }
//~~~~~~~
}

Actual Result

const o: HasVoidMethod = {
  async f() { }
//       ~~~~~~
}

Additional Info

For methods, should probably underline an explicitly provided return type if present. Otherwise, use the getFunctionHeadLoc utility.

@kirkwaiblinger kirkwaiblinger added bug Something isn't working package: eslint-plugin Issues related to @typescript-eslint/eslint-plugin triage Waiting for team members to take a look labels Oct 26, 2024
@bradzacher bradzacher added accepting prs Go ahead, send a pull request that resolves this issue and removed triage Waiting for team members to take a look labels Oct 26, 2024
@kirkwaiblinger kirkwaiblinger changed the title Bug: [no-misused-promises] bad report loc for report methods in object literals Bug: [no-misused-promises] bad report loc for methods in object literals Oct 26, 2024
@gyumong
Copy link
Contributor

gyumong commented Oct 27, 2024

If no one is currently assigned, I would like to work on resolving this issue.

@kirkwaiblinger
Copy link
Member Author

Go for it! We invite contributions for things marked "accepting prs" 🙂

https://typescript-eslint.io/contributing/pull-requests

@github-actions github-actions bot added the locked due to age Please open a new issue if you'd like to say more. See https://typescript-eslint.io/contributing. label Nov 18, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 18, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
accepting prs Go ahead, send a pull request that resolves this issue bug Something isn't working locked due to age Please open a new issue if you'd like to say more. See https://typescript-eslint.io/contributing. package: eslint-plugin Issues related to @typescript-eslint/eslint-plugin
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants