Skip to content

Bug: [no-deprecated] No warnings about usage of deprecated props in JSX components #10275

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
4 tasks done
alice-ep opened this issue Nov 4, 2024 · 1 comment · Fixed by #10374
Closed
4 tasks done
Labels
accepting prs Go ahead, send a pull request that resolves this issue bug Something isn't working locked due to age Please open a new issue if you'd like to say more. See https://typescript-eslint.io/contributing. package: eslint-plugin Issues related to @typescript-eslint/eslint-plugin

Comments

@alice-ep
Copy link

alice-ep commented Nov 4, 2024

Before You File a Bug Report Please Confirm You Have Done The Following...

  • I have tried restarting my IDE and the issue persists.
  • I have updated to the latest version of the packages.
  • I have searched for related issues and found none that matched my issue.
  • I have read the FAQ and my problem is not listed.

Playground Link

https://typescript-eslint.io/play/#ts=5.5.4&fileType=.tsx&code=JYWwDg9gTgLgBAKjgQwM5wEoFNkGN4BmUEIcA5FDvmQNwCwAUI8AHYxZQF5ZwAKxYdAG9GcOAHoECUWKQABACZYwlXMnYKZicTKUqsajfwhgAXHFQworAOb0GAX0aNcEFpbgBhEmcxUYAHQAYp4APMaCAHxwALxwABRCcHqq6lgKEXAOAJSx0fEyoQrAAG4o1sgAtDZQyABGdemRWnAAEsCF4sUlzQzZ9i5uHsgsEDAAFhwAogAeyOAANjxxod7gycqpRgIxAEQQ43CjuxKRNEA&eslintrc=N4KABGBEBOCuA2BTAzpAXGUEKQAIBcBPABxQGNoBLY-AWhXkoDt8B6Jge1oBNFjpEZAIb5E3dFADuQ6E0jgwAXxCKgA&tsconfig=N4KABGBEDGD2C2AHAlgGwKYCcDyiAuysAdgM6QBcYoEEkJemy0eAcgK6qoDCAFutAGsylBm3TgwAXxCSgA&tokens=false

Repro Code

import * as React from 'react';

interface Props {
  /**
   * @deprecated
   */
  deprecatedProp: string;
}

const Comp: React.FC<Props> = ({ deprecatedProp }) => (
  <div aria-grabbed>
    Hi
  </div>
);

const anotherExample = <Comp deprecatedProp="oh no" />;

ESLint Config

{
  "rules": {
    "@typescript-eslint/no-deprecated": "warn"
  }
}

tsconfig

{
  "compilerOptions": {
    "strictNullChecks": true
  }
}

Expected Result

I expect to see a warning for the line that uses 'aria-dragged' and for the last line.

Actual Result

No warnings, though TypeScript does recognize the deprecation.

Additional Info

fwiw, seems like this was an issue in eslint-plugin-deprecated too. Someone tried to solve this separately (I haven't checked if it works): https://github.com/sebakerckhof/eslint-plugin-deprecated-jsx-props

@alice-ep alice-ep added bug Something isn't working package: eslint-plugin Issues related to @typescript-eslint/eslint-plugin triage Waiting for team members to take a look labels Nov 4, 2024
@JoshuaKGoldberg JoshuaKGoldberg changed the title Bug: [no-deprecated] No warnings about usage of deprecated props in React components Bug: [no-deprecated] No warnings about usage of deprecated props in JSX components Nov 4, 2024
@JoshuaKGoldberg JoshuaKGoldberg added accepting prs Go ahead, send a pull request that resolves this issue and removed triage Waiting for team members to take a look labels Nov 4, 2024
@JoshuaKGoldberg
Copy link
Member

Note that this isn't specific to React; it's all JSX libraries.

@github-actions github-actions bot added the locked due to age Please open a new issue if you'd like to say more. See https://typescript-eslint.io/contributing. label Dec 19, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 19, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
accepting prs Go ahead, send a pull request that resolves this issue bug Something isn't working locked due to age Please open a new issue if you'd like to say more. See https://typescript-eslint.io/contributing. package: eslint-plugin Issues related to @typescript-eslint/eslint-plugin
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants