Skip to content

Bug: [no-misused-spread] False negative for spread in JSX #10648

Closed
@OliverJAsh

Description

@OliverJAsh

Before You File a Bug Report Please Confirm You Have Done The Following...

  • I have tried restarting my IDE and the issue persists.
  • I have updated to the latest version of the packages.
  • I have searched for related issues and found none that matched my issue.
  • I have read the FAQ and my problem is not listed.

Playground Link

https://typescript-eslint.io/play/#ts=5.7.2&fileType=.tsx&code=CYUwxgNghgTiAEYD2A7AzgF3gDwFzwAoBKeAXgD5CBveAMySX0xgEsUBzeAXyIG4AofgHoh8QKDk8ENgAO4DCGCSYMJDAA08dkiwhlq-gRoA6E9m59BI%2BIBlySTLkKlK9Zu3wUqEPwA8wFgDd4KhMjbC54IXJeIA&eslintrc=N4KABGBEBOCuA2BTAzpAXGUEKQAIBcBPABxQGNoBLY-AWhXkoDt8B6Jge1oFtLlZkiACa1kxaIgCGQ9GABM4MAF8QSoA&tsconfig=N4KABGBEDGD2C2AHAlgGwKYCcDyiAuysAdgM6QBcYoEEkJemy0eAcgK6qoDCAFutAGsylBm3TgwAXxCSgA&tokens=false

Repro Code

declare const x: () => ({ foo: string });

// ✅ expected error, got error
({ ...x });

// ❌ expected error, got none
<div {...x} />;

ESLint Config

{
  "rules": {
    "@typescript-eslint/no-misused-spread": 2
  }
}

tsconfig

No response

Expected Result

See above.

Actual Result

See above.

Additional Info

It looks like we're matching against SpreadElement but not JSXSpreadAttribute.

Metadata

Metadata

Assignees

No one assigned

    Labels

    accepting prsGo ahead, send a pull request that resolves this issuebugSomething isn't workinglocked due to agePlease open a new issue if you'd like to say more. See https://typescript-eslint.io/contributing.package: eslint-pluginIssues related to @typescript-eslint/eslint-plugin

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions