Skip to content

How do I know what version range of eslint is supported? #1065

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
NickHeiner opened this issue Oct 11, 2019 · 4 comments
Closed

How do I know what version range of eslint is supported? #1065

NickHeiner opened this issue Oct 11, 2019 · 4 comments
Labels
question Questions! (i.e. not a bug / enhancment / documentation)

Comments

@NickHeiner
Copy link
Contributor

I'm stuck on ESLint 5 for the time being. I'd like to use the latest version of this package so I can use TS 3.6. However, I don't know if that'll work. I see that the dev dep on ESLint is ^6, but I'm not sure what that means for this project's formal support goals.

I scanned the README but couldn't find any info about this there. That could be a good place to officially note this 😄.
@bradzacher bradzacher added the question Questions! (i.e. not a bug / enhancment / documentation) label Oct 11, 2019
@bradzacher
Copy link
Member

The best, most up-to-date place to see this is the package.json for the plugin:

typescript-eslint/packages/eslint-plugin/package.json

Line 60 in 526d336

"eslint": "^5.0.0 || ^6.0.0"

Note that we do not test against eslint v5 any more, but there wasn't any breaking changes between v5 and v6 that should stop anything working for you.

@NickHeiner
Copy link
Contributor Author

Thanks for the quick response!

I would recommend putting noting in the README that typescript-eslint/packages/eslint-plugin/package.json is the place to look. That would have saved me from needing to bother you on this.

@bradzacher
Copy link
Member

happy to accept a PR!

@NickHeiner
Copy link
Contributor Author

Heh, fair enough.

NickHeiner added a commit to NickHeiner/typescript-eslint that referenced this issue Oct 11, 2019
@NickHeiner
Make clear which versions of ESLint are supported.
3d474ec 
Related: typescript-eslint#1065.
@NickHeiner NickHeiner mentioned this issue Oct 11, 2019
Merged
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 20, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
question Questions! (i.e. not a bug / enhancment / documentation)
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@NickHeiner @bradzacher