Skip to content

Repo: [strict-boolean-expressions.test.ts] Switch auto-generated test cases to hand-written #11051

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
JoshuaKGoldberg opened this issue Apr 9, 2025 · 0 comments · Fixed by #11296
Labels
accepting prs Go ahead, send a pull request that resolves this issue repo maintenance things to do with maintenance of the repo, and not with code/docs

Comments

@JoshuaKGoldberg
Copy link
Member

Suggestion

Some RuleTester tests in this repo are generated dynamically. Auto-generating tests like that can help create comprehensive test coverage for rules - but:

We'd like to move away from these auto-generated / dynamic test cases. That specifically means making all test cases passed to RuleTester be completely inline plain old JavaScript objects. No .flatMaps/.maps, no dedupeTestCases, helper functions, etc.

This issue tracks doing so for packages/eslint-plugin/tests/rules/strict-boolean-expressions.test.ts.

Additional Info

💖

@JoshuaKGoldberg JoshuaKGoldberg added accepting prs Go ahead, send a pull request that resolves this issue repo maintenance things to do with maintenance of the repo, and not with code/docs labels Apr 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accepting prs Go ahead, send a pull request that resolves this issue repo maintenance things to do with maintenance of the repo, and not with code/docs
Projects
None yet
2 participants
@JoshuaKGoldberg and others