Skip to content

[2.4.0][Watch] OUT OF MEMORY on node 10 #1107

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
Hotell opened this issue Oct 19, 2019 · 2 comments · Fixed by #1106
Closed

[2.4.0][Watch] OUT OF MEMORY on node 10 #1107

Hotell opened this issue Oct 19, 2019 · 2 comments · Fixed by #1106
Labels
bug Something isn't working package: typescript-estree Issues related to @typescript-eslint/typescript-estree

Comments

@Hotell
Copy link
Contributor

Hotell commented Oct 19, 2019

maybe related to #1091 ?

What did you expect to happen?

lint should work as before

What actually happened?

after bumping to 2.4.0 I got out of memory error image

not present with 2.3.3.

Versions

package version
@typescript-eslint/parser 2.4.0
TypeScript 3.6.4
ESLint 6.5.1
node 10.16.1
yarn 1.19
@Hotell Hotell added package: parser Issues related to @typescript-eslint/parser triage Waiting for team members to take a look labels Oct 19, 2019
@bradzacher bradzacher mentioned this issue Oct 19, 2019
Merged
@bradzacher bradzacher changed the title 2.4.0 throws OUT OF MEMORY on node 10 [2.4.0][Watch] OUT OF MEMORY on node 10 Oct 19, 2019
@bradzacher bradzacher added bug Something isn't working package: typescript-estree Issues related to @typescript-eslint/typescript-estree and removed package: parser Issues related to @typescript-eslint/parser triage Waiting for team members to take a look labels Oct 19, 2019
@bradzacher
Copy link
Member

As you probably read on the other issues, I added some to add some weak file watching to attempt to support the IDE use case. TBH this code wasn't great, missed a lot of cases, and didn't work well across OSs.

I've just landed #1106, and it will be deployed to the canary tag imminently.
This change reworks the invalidation approach so that it doesn't need file watchers at all.

I'd appreciate if you could take a moment to test the canary tag on your codebase, and let me know if anything isn't working as expected for your real-world codebase.

@Hotell
Copy link
Contributor Author

Hotell commented Oct 21, 2019

fixed in 2.4.1-alpha.9 👍

@ghost ghost mentioned this issue Oct 24, 2019
Closed
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 20, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
bug Something isn't working package: typescript-estree Issues related to @typescript-eslint/typescript-estree
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(typescript-estree): support long running lint without watch typescript-eslint/typescript-eslint
2 participants
@Hotell @bradzacher