Skip to content

Bug: Updating to 8.30.0 breaks eslintrc preset configs #11071

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
4 tasks done
gardsa opened this issue Apr 14, 2025 · 9 comments · Fixed by #11072
Closed
4 tasks done

Bug: Updating to 8.30.0 breaks eslintrc preset configs #11071

gardsa opened this issue Apr 14, 2025 · 9 comments · Fixed by #11072
Assignees
@kirkwaiblinger
Labels
accepting prs Go ahead, send a pull request that resolves this issue bug Something isn't working locked due to age Please open a new issue if you'd like to say more. See https://typescript-eslint.io/contributing.

Comments

@gardsa
Copy link

gardsa commented Apr 14, 2025 •
edited
Loading

Before You File a Bug Report Please Confirm You Have Done The Following...

  • I have tried restarting my IDE and the issue persists.
  • I have updated to the latest version of the packages.
  • I have searched for related issues and found none that matched my issue.
  • I have read the FAQ and my problem is not listed.

Relevant Package

eslint-plugin

Playground Link

No response

Repro Code

// Package.json

{
  scripts: {
    "check:lint": "eslint 'src/**/*'",
  },
  devDependencies: {
    "@typescript-eslint/eslint-plugin": "^8.30.0",
  }
}

Expected Result

I would expect that yarn check:lint would result in my linting process to run, and get the following output:

Done in XX.XXs.

Actual Result

When I run yarn check:lint, I get the following error output:

Oops! Something went wrong! :(

ESLint: 9.24.0

ESLint couldn't find the config "./configs/base" to extend from. Please check that the name of the config is correct.

The config "./configs/base" was referenced from the config file in "/app/node_modules/@typescript-eslint/eslint-plugin/dist/index.js".

If you still have problems, please stop by https://eslint.org/chat/help to chat with the team.

Additional Info

This error began occurring in a dependabot PR in which both @typescript-eslint/eslint-plugin and @typescript-eslint/parser were updated to 8.30.0.

I was able to isolate the error as part of @typescript-eslint/eslint-plugin by downgrading both packages back to 8.29.1 (our previous version) and then upgrading both separately to see how the issue persisted. My linting checks ran fine with the upgrade of @typescript-eslint/parser to 8.30.0.

Versions

package version
@typescript-eslint/eslint-plugin 8.30.0
@typescript-eslint/parser 8.30.0
TypeScript 5.8.3
ESLint 9.24.0
node 22.1.0
@gardsa gardsa added bug Something isn't working triage Waiting for team members to take a look labels Apr 14, 2025
@JoshuaKGoldberg
Copy link
Member

@kirkwaiblinger, something from #10973 perhaps?

@lhtdesignde
Copy link

Seeing the same. Just confirming that 8.29.1 of eslint-plugin works fine. bugs shows up starting 8.30.0.

@sators
Copy link

sators commented Apr 14, 2025

I also confirm this issue occuring with 8.30.0. 8.29.1 also works fine for me.

Updated package.json to "~8.29.1" and then npm i to remedy.

@JoshuaKGoldberg JoshuaKGoldberg added accepting prs Go ahead, send a pull request that resolves this issue and removed triage Waiting for team members to take a look labels Apr 14, 2025
@kirkwaiblinger
Copy link
Member

Hi! Could someone experiencing this issue post more detail about their eslint config or, preferably, make a minimal reproduction repo? I have not been able to reproduce this myself yet.

@kirkwaiblinger
Copy link
Member

Actually - I've been able to repro it now using an eslintrc setup. I'm assuming that's the setup with which people are experiencing issues?

@kirkwaiblinger kirkwaiblinger mentioned this issue Apr 14, 2025
Merged
3 tasks
@anthony-bonta-gaf-energy
Copy link

ESLint config

// Blah blah
"extends": [
    // Blah Blah
    "plugin:@typescript-eslint/recommended",
  ],

Problem is here:

// node_modules/typescript-eslint/eslint-plugin/dist/configs/eslintrc
extends: ['./configs/base', './configs/eslint-recommended'],

// Needs to be
extends: ['./configs/eslintrc/base', './configs/eslintrc/eslint-recommended']

@kirkwaiblinger kirkwaiblinger changed the title Bug: Updating to 8.30.0 gives error that "./configs/base" cannot be found Bug: Updating to 8.30.0 breaks eslintrc preset configs Apr 14, 2025
@gardsa
Copy link
Author

gardsa commented Apr 14, 2025

Actually - I've been able to repro it now using an eslintrc setup. I'm assuming that's the setup with which people are experiencing issues?

We have an eslint.config.mjs set up actually

@kirkwaiblinger
Copy link
Member

There was indeed an obvious regression with our eslintrc configs (as noticed by @anthony-bonta-gaf-energy 🙂) that accounts for the observed error in an eslintrc setup. The fix has been pushed out already in 8.30.1 🥳

@gardsa if you're able to repro after the patch, would you kindly file another issue including a reproduction? Thanks!

@gardsa
Copy link
Author

gardsa commented Apr 14, 2025

@gardsa if you're able to repro after the patch, would you kindly file another issue including a reproduction? Thanks!

No issue for us now - thanks a lot for the quick fix!

@joe-yeager joe-yeager mentioned this issue Apr 15, 2025
Merged
@github-actions github-actions bot added the locked due to age Please open a new issue if you'd like to say more. See https://typescript-eslint.io/contributing. label Apr 22, 2025
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 22, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@kirkwaiblinger kirkwaiblinger

Labels
accepting prs Go ahead, send a pull request that resolves this issue bug Something isn't working locked due to age Please open a new issue if you'd like to say more. See https://typescript-eslint.io/contributing.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(eslint-plugin): fix mistake with eslintrc config generation kirkwaiblinger/typescript-eslint
6 participants
@sators @JoshuaKGoldberg @lhtdesignde @gardsa @kirkwaiblinger @anthony-bonta-gaf-energy