Skip to content

[unbound-method] Doesn't work on destructuring declarations #1112

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
Validark opened this issue Oct 20, 2019 · 2 comments · Fixed by #2228
Closed

[unbound-method] Doesn't work on destructuring declarations #1112

Validark opened this issue Oct 20, 2019 · 2 comments · Fixed by #2228
Labels
bug Something isn't working package: eslint-plugin Issues related to @typescript-eslint/eslint-plugin

Comments

@Validark
Copy link
Contributor

Repro

{
  "rules": {
    "@typescript-eslint/unbound-method": "warn"
  }
}
class MyClass {
	public log(): void {
		print(this);
	}
}

const instance = new MyClass();

const myLog = instance.log; // properly caught
myLog();

const { log } = instance; // no problem ?

log();

Expected Result const { log } = instance; should get reported as bad

Actual Result const { log } = instance; is not reported

Additional Info

Versions

package version
@typescript-eslint/eslint-plugin 2.3.2
@typescript-eslint/parser 2.3.2
TypeScript 3.6.4
ESLint 6.5.1
node 12.9.1
npm 6.11.2
@Validark Validark added package: eslint-plugin Issues related to @typescript-eslint/eslint-plugin triage Waiting for team members to take a look labels Oct 20, 2019
@bradzacher bradzacher added enhancement New feature or request and removed triage Waiting for team members to take a look labels Oct 20, 2019
@OliverJAsh
Copy link
Contributor

👍. Also, note that the example in the docs suggests the destructuring variant should error, so either this is a bug or the docs are a bit misleading?

@bradzacher
Copy link
Member

Hmm, sometimes I don't know a rule well enough to catch things like that when triaging. Thanks for flagging.

Looking closer at the tests, they are pretty clearly written incorrectly, which is probably why this isn't working

typescript-eslint/packages/eslint-plugin/tests/rules/unbound-method.test.ts

Lines 217 to 220 in 6aa6bc7

{
const { unbound } = instance.unbound;
const { unboundStatic } = ContainsMethods.unboundStatic;
}

@bradzacher bradzacher added bug Something isn't working and removed enhancement New feature or request labels Jan 8, 2020
@OliverJAsh OliverJAsh mentioned this issue Jan 9, 2020
Closed
@yeonjuan yeonjuan mentioned this issue Jun 19, 2020
Merged
@bradzacher bradzacher mentioned this issue Jun 19, 2020
Closed
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 21, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
bug Something isn't working package: eslint-plugin Issues related to @typescript-eslint/eslint-plugin
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(eslint-plugin): [unbound-method] handling destructuring
3 participants
@OliverJAsh @bradzacher @Validark