Skip to content

Bug: Visitor keys for ExportSpecifier are not in source code order #11293

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
4 tasks done
overlookmotel opened this issue Jun 10, 2025 · 0 comments · Fixed by #11294
Closed
4 tasks done

Bug: Visitor keys for ExportSpecifier are not in source code order #11293

overlookmotel opened this issue Jun 10, 2025 · 0 comments · Fixed by #11294
Labels
accepting prs Go ahead, send a pull request that resolves this issue bug Something isn't working dependencies Issue about dependencies of the package

Comments

@overlookmotel
Copy link
Contributor

overlookmotel commented Jun 10, 2025

Before You File a Bug Report Please Confirm You Have Done The Following...

  • I have tried restarting my IDE and the issue persists.
  • I have updated to the latest version of the packages.
  • I have searched for related issues and found none that matched my issue.
  • I have read the FAQ and my problem is not listed.

Relevant Package

visitor-keys

Playground Link

No response

Repro Code

export { local as exported }

ESLint Config

tsconfig

Expected Result

Visitation order for ExportSpecifier is incorrect - exported is visited before local.

@typescript-eslint/visitor-keys inherits this problem from eslint-visitor-keys (as discussed in #11279). It has been fixed in eslint/js#655, which is included in eslint-visitor-keys v4.2.1, which was released today.

As far as I can see, this is the only substantive change made in v4.2.1, so I think it should be possible to bump eslint-visitor-keys dependency without upgrading to latest eslint, and it shouldn't affect anything else.

Actual Result

n/a

Additional Info

No response

Versions

package version
@typescript-eslint/visitor-keys 8.34.0
@overlookmotel overlookmotel added bug Something isn't working triage Waiting for team members to take a look labels Jun 10, 2025
@overlookmotel overlookmotel changed the title Bug: Bump eslint-visitor-keys dependency to fix visitor keys for ExportSpecifier Bug: Visitor keys for ExportSpecifier are not in source code order Jun 10, 2025
@bradzacher bradzacher added dependencies Issue about dependencies of the package accepting prs Go ahead, send a pull request that resolves this issue and removed triage Waiting for team members to take a look labels Jun 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accepting prs Go ahead, send a pull request that resolves this issue bug Something isn't working dependencies Issue about dependencies of the package
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants