Skip to content

chore(visitor-keys): bump eslint-visitor-keys dependency #11294

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

overlookmotel
Copy link
Contributor

@overlookmotel overlookmotel commented Jun 10, 2025

PR Checklist

Overview

Fix #11293 by bumping dependency of eslint-visitor-keys to v4.2.1.

As mentioned in #11293, as far as I can see, this is the only substantive change made in v4.2.1, so I think it should be possible to bump eslint-visitor-keys dependency in isolation, without breaking anything else.

No-one has had a chance to respond on #11293 yet, so I'm jumping the gun by submitting a PR. However, judging by #11279, I assume this will be considered a bug, and I thought a PR would help verify that this fix doesn't break anything.

If I'm out of line, please feel free to close this!

@typescript-eslint
Copy link
Contributor

Thanks for the PR, @overlookmotel!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!


🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint.

Copy link

netlify bot commented Jun 10, 2025

Deploy Preview for typescript-eslint ready!

Name Link
🔨 Latest commit 1380b73
🔍 Latest deploy log https://app.netlify.com/projects/typescript-eslint/deploys/684874d2d1a2700008419336
😎 Deploy Preview https://deploy-preview-11294--typescript-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 99 (no change from production)
Accessibility: 100 (no change from production)
Best Practices: 92 (🔴 down 8 from production)
SEO: 98 (no change from production)
PWA: 80 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify project configuration.

Copy link

nx-cloud bot commented Jun 10, 2025

View your CI Pipeline Execution ↗ for commit 1380b73.

Command Status Duration Result
nx test eslint-plugin --coverage=false ✅ Succeeded 5m 4s View ↗
nx run-many -t typecheck ✅ Succeeded 1m 54s View ↗
nx test typescript-estree --coverage=false ✅ Succeeded 18s View ↗
nx test eslint-plugin-internal --coverage=false ✅ Succeeded 7s View ↗
nx run-many -t lint ✅ Succeeded 10s View ↗
nx run types:build ✅ Succeeded 9s View ↗
nx run integration-tests:test ✅ Succeeded <1s View ↗
nx run generate-configs ✅ Succeeded 11s View ↗
Additional runs (27) ✅ Succeeded ... View ↗

☁️ Nx Cloud last updated this comment at 2025-06-10 18:20:45 UTC

Copy link
Member

@bradzacher bradzacher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@bradzacher bradzacher merged commit 445514a into typescript-eslint:main Jun 10, 2025
66 of 67 checks passed
@overlookmotel overlookmotel deleted the bump-eslint-visitor-keys branch June 11, 2025 11:47
@fisker
Copy link
Contributor

fisker commented Jun 12, 2025

Out of curiosity, why are we not using workspace:^? Not supported?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: Visitor keys for ExportSpecifier are not in source code order
3 participants