Skip to content

Lodash is deprecating per method packages #1399

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
armano2 opened this issue Jan 2, 2020 · 2 comments · Fixed by #1430
Closed

Lodash is deprecating per method packages #1399

armano2 opened this issue Jan 2, 2020 · 2 comments · Fixed by #1430
Labels
dependencies Issue about dependencies of the package external This issue is with another package, not typescript-eslint itself

Comments

@armano2
Copy link
Collaborator

armano2 commented Jan 2, 2020 •
edited
Loading

Loadash is slowly deprecating "per module packages" in favor of single package that contains all of scripts.

currently we are using:

What are our plans for this? Do we want to drop unescape from dependencies or do we want to migrate to lodash/unescape.

Reference:
@armano2 armano2 added external This issue is with another package, not typescript-eslint itself dependencies Issue about dependencies of the package labels Jan 2, 2020
@armano2 armano2 changed the title Lodash is deprecating Per Method Packages Lodash is deprecating per method packages Jan 2, 2020
@bradzacher
Copy link
Member

Do we need to drop the package or even upgrade it? What do we get from bothering to upgrade to v5?
It's not a large piece of code, so it's not like it's a security risk or anything.

@armano2
Copy link
Collaborator Author

armano2 commented Jan 2, 2020

keeping dependencies up to date reduces dependency tree of developers :>

v5 is not yet live, this is just reminder that we should look into this

@armano2 armano2 mentioned this issue Jan 11, 2020
Merged
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 20, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
dependencies Issue about dependencies of the package external This issue is with another package, not typescript-eslint itself
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore: migrate lodash from function packages
2 participants
@armano2 @bradzacher