Skip to content

(eslint-plugin) Bump ESLint major version in Peer Dependencies #145

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
adamelliotfields opened this issue Jan 26, 2019 · 4 comments · Fixed by #151
Closed

(eslint-plugin) Bump ESLint major version in Peer Dependencies #145

adamelliotfields opened this issue Jan 26, 2019 · 4 comments · Fixed by #151
Labels
bug Something isn't working package: eslint-plugin Issues related to @typescript-eslint/eslint-plugin

Comments

@adamelliotfields
Copy link
Contributor

When using ESLint v5, I've had no issues 👍

However, with ESLint v4, I cannot get ESLint to locate the plugin. The following error is logged:

Oops! Something went wrong! :(

ESLint: 4.19.1.
ESLint couldn't find the plugin "eslint-plugin-@typescript-eslint".

I've tried a few variations of the naming, like "@typescript-eslint/eslint-plugin" and "@typescript-eslint/", to no avail.

Since there's clearly a difference in the way ESLint v4 resolves plugins, would it be worthwhile to change the peerDependencies to "eslint": ">=5 < 6"?

Repro

./node_modules/.bin/eslint src/**/*.ts
{
  "extends": ["airbnb-base", "plugin:@typescript-eslint/recommended"],
  "parser": "@typescript-eslint/parser",
  "plugins": ["@typescript-eslint"],
  "settings": {
    "import/resolver": { "typescript": {} }
  }
}

Versions

package version
@typescript-eslint/eslint-plugin 1.1.0
@typescript-eslint/parser 1.1.0
TypeScript 3.2.4
ESLint 4.19.1
node 8.4.0
npm 5.3.0
@adamelliotfields adamelliotfields added package: eslint-plugin Issues related to @typescript-eslint/eslint-plugin triage Waiting for team members to take a look labels Jan 26, 2019
@bradzacher bradzacher added bug Something isn't working and removed triage Waiting for team members to take a look labels Jan 26, 2019
@bradzacher
Copy link
Member

yeah they only added support for scoped plugins in eslint v5.
We talked about updating the dependency version, but forgot about it!

@adamelliotfields
Copy link
Contributor Author

No worries Brad! I assume most people are running the latest version.

I’d be glad to submit a quick PR updating the package.json for each package, unless you want to wrap it into another feature you’re already working on.

@bradzacher
Copy link
Member

feel free to submit a PR, if you would like.

Always better to have this sort of thing as a separate PR for clarity in the commit log anyways :)

@adamelliotfields
Copy link
Contributor Author

I hear you!

I’ll get something up for review in a few hours - currently on the road.

Looks like I’ll need to update the plugin, parser, and tslint packages.

@adamelliotfields adamelliotfields changed the title (eslint-plugin) Cannot load plugin with ESLint v4 (eslint-plugin) Bump ESLint major version in Peer Dependencies Jan 27, 2019
@adamelliotfields adamelliotfields mentioned this issue Jan 27, 2019
Merged
2 tasks
@typescript-eslint typescript-eslint locked as resolved and limited conversation to collaborators Feb 21, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
bug Something isn't working package: eslint-plugin Issues related to @typescript-eslint/eslint-plugin
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore: Update peer dependencies and Node engines
2 participants
@adamelliotfields @bradzacher