Skip to content

(eslint-plugin) Bump ESLint major version in Peer Dependencies #145

Closed
@adamelliotfields

Description

@adamelliotfields

When using ESLint v5, I've had no issues 👍

However, with ESLint v4, I cannot get ESLint to locate the plugin. The following error is logged:

Oops! Something went wrong! :(

ESLint: 4.19.1.
ESLint couldn't find the plugin "eslint-plugin-@typescript-eslint".

I've tried a few variations of the naming, like "@typescript-eslint/eslint-plugin" and "@typescript-eslint/", to no avail.

Since there's clearly a difference in the way ESLint v4 resolves plugins, would it be worthwhile to change the peerDependencies to "eslint": ">=5 < 6"?

Repro

./node_modules/.bin/eslint src/**/*.ts
{
  "extends": ["airbnb-base", "plugin:@typescript-eslint/recommended"],
  "parser": "@typescript-eslint/parser",
  "plugins": ["@typescript-eslint"],
  "settings": {
    "import/resolver": { "typescript": {} }
  }
}

Versions

package version
@typescript-eslint/eslint-plugin 1.1.0
@typescript-eslint/parser 1.1.0
TypeScript 3.2.4
ESLint 4.19.1
node 8.4.0
npm 5.3.0

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't workingpackage: eslint-pluginIssues related to @typescript-eslint/eslint-plugin

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions