The base camelcase rule only matched identifiers, yes - so it skipped literals.

I don't think I agree with this entirely, as literal prop names could then slip through, accidentally circumventing the rule.

/*
eslint '@typescript-eslint/naming-convention': [
			'error',
			{
				selector: 'default',
				format: [
					'strictCamelCase'
				],
				leadingUnderscore: 'allow',
				trailingUnderscore: 'allow'
			}
		}
*/
const x = {
  'Skip This': 1, // sure, it seems obvious that this should be skipped
  x_x: 1, // error - not in strictCamelCase
  'y_y': 1, // this should error too, right?
}

A surprising number of people don't use prettier, and the base quote-props rule isn't recommended, so it's easy for people to accidentally quote props.

I don't know the best solution here. Part of me thinks maybe this is just an eslint-disable case. Unsure, need to think some more. Maybe it should inspect the name to see if it requires quotes, and ignores it if it does?

as literal prop names could then slip through, accidentally circumventing the rule.

I would argue that's an explicit intent on using something else.

A surprising number of people don't use prettier, and the base quote-props rule isn't recommended, so it's easy for people to accidentally quote props.

You could make it an option to ignore quote object literal keys or expose the type so I can manually ignore it myself.

Part of me thinks maybe this is just an eslint-disable case.

It's quite a common use-case though. You would then force pretty much any server-related app to use lots of eslint-disable comments as you kinda have to do this when dealing with HTTP headers.

Maybe it should inspect the name to see if it requires quotes, and ignores it if it does?

That would be the preferred solution, yes.

Hello people. Thank you for the excellent work with this tool.

I'm having the same problem. Is there any way to resolve it other than to disable it as a comment?

Maybe it should inspect the name to see if it requires quotes, and ignores it if it does?

Digging into this - it's actually really, really, really hard to tell if a string is a valid identifier. The grammar for an identifier is very permissive.

The only way to do this reliably would be to add an external library, and I don't hugely want to do that.

Prettier uses esutils to do this:

https://github.com/prettier/prettier/blob/82676f6308322496d71d8ea43853190e710e678f/src/language-js/utils.js#L728-L741

And you can see the regexes esutils auto-generates to do this check here:
https://github.com/estools/esutils/blob/a825f91fd1d1e3a9fff84227cb06c011d8a0b9e8/lib/code.js#L31-L37

However, I never thought about this - but this is entirely achievable from a configuration standpoint.

You can use the filter option to ignore specific names only:

{
  "@typescript-eslint/naming-convention": [
    "error",
    {
      "selector": "property",
      "format": ["strictCamelCase"],
      "filter": {
        // you can expand this regex to add more allowed names
        "regex": "^(Property-Name-One|Property-Name-Two)$",
        "match": false
      }
    }
  ]
}

You can use the filter option to ignore names that require quoting:

{
  "@typescript-eslint/naming-convention": [
    "error",
    {
      "selector": "property",
      "format": ["strictCamelCase"],
      "filter": {
        // you can expand this regex as you find more cases that require quoting that you want to allow
        "regex": "[-]",
        "match": false
      }
    }
  ]
}

I have updated the documentation appropriately.

Hello, thank you very much for responding to our problem.

Sorry if I didn't understand the way you solved the problem, but for my case I had to do it a little differently. I had the following case:

const headers = {
    'Retry-After': retryAfter,
    'X-RateLimit-Limit': limit,
    'X-RateLimit-Remaining': remaining,
    'X-RateLimit-Reset': resete
}

And to resolve, based on your help I did so:

{
    "selector": "property",
    "format": ["PascalCase"],
    "filter": {
        "regex": "[-]",
        "match": true
    }
}

The only way to do this reliably would be to add an external library, and I don't hugely want to do that.

Instead, you're putting the burden on every user.

Couldn't ESLint potentially expose an utility for this?

burden on every user

only users that set headers via string keys. There aren't many other common use cases that I know of. I believe that this is a small fraction of users.

Even then using a configuration option as above is better as you can thoroughly customise the allowed formats and names based on your use case.

For example:

• one codebase might specify a custom format that only allows string keys in the form Foo-Bar
• another might specifically whitelist what string keys are allowed,
• and a final one might just allow any string key with a - in it.

The configuration is flexible so you can apply the level of strictness you want (which is the entire point of merging all the naming rules together).

Having an ignoreStringKeys option is far reaching, and means you could (esp without prettier) have names like 'foo_bar' or 'Foo Bar' in when you only wanted to allow 'Foo-Bar'.

Couldn't ESLint potentially expose an utility for this?

ESLint exposes no utilities to help with writing rules.
eslint-utils is the closest analogy, and that is technically 3rd-party.

I believe that this is a small fraction of users.

Neither of us have any proof on that. It's common when doing HTTP requests.

The configuration is flexible so you can apply the level of strictness you want (which is the entire point of merging all the naming rules together).

Flexibility is great, but I also feel that defaults should be good.

Having an ignoreStringKeys option is far reaching

Yes, I wouldn't want such an option. Agreed.

ESLint exposes no utilities to help with writing rules.

It should though, but I realize this is not the place to discuss that.

Just notifying anyone subscribed to this issue - #2813 adds the requiresQuotes modifier for member-like things.
This modifier will specifically match names that require quotes.

If you simply want to allow all property names that require quotes, you can use the requiresQuotes modifier to match any property name that requires quoting, and use format: null to ignore the name.

New example from the docs for ignoring property names that require quotes (you can customise this to limit it if you see fit).

{
  "@typescript-eslint/naming-convention": [
    "error",
    {
      "selector": [
        "classProperty",
        "objectLiteralProperty",
        "typeProperty",
        "classMethod",
        "objectLiteralMethod",
        "typeMethod",
        "accessor",
        "enumMember"
      ],
      "format": null,
      "modifiers": ["requiresQuotes"]
    }
  ]
}