Skip to content

eslint-plugin-tslint should support tslint 6 #1808

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
crfrolik opened this issue Mar 26, 2020 · 3 comments · Fixed by #1809
Closed

eslint-plugin-tslint should support tslint 6 #1808

crfrolik opened this issue Mar 26, 2020 · 3 comments · Fixed by #1809
Labels
dependencies Issue about dependencies of the package good first issue Good for newcomers package: eslint-plugin-tslint Issues related to @typescript-eslint/eslint-plugin-tslint

Comments

@crfrolik
Copy link
Contributor

This warning is printed by yarn:

@typescript-eslint/eslint-plugin-tslint@2.25.0" has incorrect peer dependency "tslint@^5.0.0".

tslint 6.1 is now released; eslint-plugin-tslint should support it (and should not generate a peer dependency warning)

Versions

package version
@typescript-eslint/eslint-plugin-tslint 2.25.0
@typescript-eslint/parser 2.25.0
TypeScript 3.8.3
ESLint 6.8.0
node 13.9.0
npm yarn 1.22.0
@crfrolik crfrolik added package: eslint-plugin-tslint Issues related to @typescript-eslint/eslint-plugin-tslint triage Waiting for team members to take a look labels Mar 26, 2020
@bradzacher
Copy link
Member

Should be a simple PR to bump the version and ensure the tests still work - want to give it a go?

@bradzacher bradzacher added enhancement New feature or request good first issue Good for newcomers dependencies Issue about dependencies of the package and removed triage Waiting for team members to take a look enhancement New feature or request labels Mar 26, 2020
@crfrolik
Copy link
Contributor Author

Sure, I'll do it. Thanks!

@bradzacher
Copy link
Member

Awesome, thanks!

Small note ahead of time - you will want to ensure it still allows tslint v5 by using the semver ||

@crfrolik crfrolik mentioned this issue Mar 26, 2020
Merged
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 25, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
dependencies Issue about dependencies of the package good first issue Good for newcomers package: eslint-plugin-tslint Issues related to @typescript-eslint/eslint-plugin-tslint
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(eslint-plugin-tslint): support tslint 6 crfrolik/typescript-eslint
2 participants
@bradzacher @crfrolik