-
-
Notifications
You must be signed in to change notification settings - Fork 2.8k
[space-before-function-paren] this rule to abstract function not work #2192
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
The rule doesn't currently check those functions. |
Ok I'll |
I'll need help to test it
|
the https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Statements/function* For how the rule works, you'd best look at the base rule, which our rule extends: It looks like if the function is a named generator function ( |
ok... this i understood :
and thanks for it :
it help me to see more examples here : but my doubt is about these scenarios present in the test:
why on first the for me... if the method has the
if the method hasn't the
what's wrong ? |
The grammar is intentionally ambiguous. As long as the Note that the exact spacing of the This is why the |
Makes sense. I was focusing on the generator and it doesn't apply here. that's my mistake. thank you very much for clarifying me. |
PR was missing the "Fixes: #2192" so this didn't get automatically closed when the fix was merged, @adrielcodeco could you close this for house keeping? |
Can anyone help to understand?
Im using vscode with eslint extension and the space-before-function-paren rule is not working for the abstract function
with this example code:
with this config:
.eslintrc
Expected Result
warn and fix space between function name and the opening paren
Actual Result
for abstract functions the behavior not working
Versions
@typescript-eslint/eslint-plugin
3.2.0
@typescript-eslint/parser
3.2.0
TypeScript
3.9.5
ESLint
7.2.0
node
14.4.0
npm
6.14.5
The text was updated successfully, but these errors were encountered: