Skip to content

[no-implied-eval,no-throw-literal,no-empty-function] Documentation missing information that eslint no-implied-eval should be turned off. #2555

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
1 of 3 tasks
radarsu opened this issue Sep 14, 2020 · 2 comments · Fixed by #2578
Labels
documentation Documentation ("docs") that needs adding/updating good first issue Good for newcomers package: eslint-plugin Issues related to @typescript-eslint/eslint-plugin

Comments

@radarsu
Copy link
Contributor

radarsu commented Sep 14, 2020

  • I have tried restarting my IDE and the issue persists.
  • I have updated to the latest version of the packages.
  • I have read the FAQ and my problem is not listed.

Repro

Go to:
https://github.com/typescript-eslint/typescript-eslint/blob/master/packages/eslint-plugin/docs/rules/no-implied-eval.md
https://github.com/typescript-eslint/typescript-eslint/blob/master/packages/eslint-plugin/docs/rules/no-throw-literal.md
https://github.com/typescript-eslint/typescript-eslint/blob/master/packages/eslint-plugin/docs/rules/no-empty-function.md
Same rules exist for eslint:
https://eslint.org/docs/rules/no-implied-eval
https://eslint.org/docs/rules/no-throw-literal
https://eslint.org/docs/rules/no-empty-function

Expected Result

There should be snippet showing that eslint equivalent should be disabled when using @typescript-eslint/rule (it is done this way in all other cases) i.e.:

{
  // note you must disable the base rule as it can report incorrect errors
  "comma-spacing": "off",
  "@typescript-eslint/comma-spacing": ["error"]
}

Actual Result

There is no information if eslint equivalent should be turned off when using plugin.

@radarsu radarsu added package: eslint-plugin Issues related to @typescript-eslint/eslint-plugin triage Waiting for team members to take a look labels Sep 14, 2020
@radarsu radarsu changed the title [no-implied-eval] Documentation missing information that eslint no-implied-eval should be turned off. [no-implied-eval,no-throw-literal,no-empty-function] Documentation missing information that eslint no-implied-eval should be turned off. Sep 14, 2020
@bradzacher
Copy link
Member

This is all open source! Happy to accept a PR!

@bradzacher bradzacher added documentation Documentation ("docs") that needs adding/updating good first issue Good for newcomers and removed triage Waiting for team members to take a look labels Sep 14, 2020
@radarsu
Copy link
Contributor Author

radarsu commented Sep 21, 2020

PR addressing this issue created #2578

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 28, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Documentation ("docs") that needs adding/updating good first issue Good for newcomers package: eslint-plugin Issues related to @typescript-eslint/eslint-plugin
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants