Skip to content

[no-unused-vars] uses non-existent deep import from eslint@5 #2890

New issue
New issue
Closed
#2917
Closed
[no-unused-vars] uses non-existent deep import from eslint@5#2890
#2917
Labels
bugSomething isn't workingpackage: eslint-pluginIssues related to @typescript-eslint/eslint-plugin
@SimenB

Description

@SimenB
SimenB
opened on Dec 21, 2020
  • I have tried restarting my IDE and the issue persists.
  • I have updated to the latest version of the packages.
  • I have read the FAQ and my problem is not listed.

Repro

Make sure to install eslint@5, which is supported according to peer dependency:

typescript-eslint/packages/eslint-plugin/package.json

Line 64 in 717e718

"eslint": "^5.0.0 || ^6.0.0 || ^7.0.0" 

{
  "rules": {
    "@typescript-eslint/no-unused-vars": ["error"]
  }
}
// empty

Expected Result

The linter should exit successfully

Actual Result

It fails due to this import, which doesn't exist for eslint@5:

typescript-eslint/packages/eslint-plugin/src/rules/no-unused-vars.ts

Line 7 in 717e718

import { getNameLocationInGlobalDirectiveComment } from 'eslint/lib/rules/utils/ast-utils';

Additional Info

Details 
eslint src/index.ts --debug
  eslint:cli CLI args: [ 'src/index.ts', '--debug' ] +0ms
  eslint:cli Running on files +4ms
  eslint:glob-utils Creating list of files to process. +0ms
  eslint:ignored-paths baseDir = "/Users/simen/repos/eslint-plugin-jest" +0ms
  eslint:ignored-paths addPatternRelativeToCwd:
  eslint:ignored-paths   original = "/node_modules/*"
  eslint:ignored-paths   cooked   = "/node_modules/*" +1ms
  eslint:ignored-paths addPatternRelativeToCwd:
  eslint:ignored-paths   original = "/bower_components/*"
  eslint:ignored-paths   cooked   = "/bower_components/*" +0ms
  eslint:ignored-paths addPatternRelativeToCwd:
  eslint:ignored-paths   original = ".*"
  eslint:ignored-paths   cooked   = ".*" +0ms
  eslint:ignored-paths addPatternRelativeToCwd:
  eslint:ignored-paths   original = "!../"
  eslint:ignored-paths   cooked   = "!../" +0ms
  eslint:ignored-paths Looking for ignore file in /Users/simen/repos/eslint-plugin-jest +0ms
  eslint:ignored-paths Loaded ignore file /Users/simen/repos/eslint-plugin-jest/.eslintignore +1ms
  eslint:ignored-paths Adding /Users/simen/repos/eslint-plugin-jest/.eslintignore +0ms
  eslint:ignored-paths addPatternRelativeToIgnoreFile:
  eslint:ignored-paths   original = "coverage/"
  eslint:ignored-paths   cooked   = "coverage/" +0ms
  eslint:ignored-paths addPatternRelativeToIgnoreFile:
  eslint:ignored-paths   original = "lib/"
  eslint:ignored-paths   cooked   = "lib/" +0ms
  eslint:ignored-paths addPatternRelativeToIgnoreFile:
  eslint:ignored-paths   original = "!.eslintrc.js"
  eslint:ignored-paths   cooked   = "!.eslintrc.js" +0ms
  eslint:ignored-paths addPatternRelativeToIgnoreFile:
  eslint:ignored-paths   original = "coverage/"
  eslint:ignored-paths   cooked   = "coverage/" +0ms
  eslint:ignored-paths addPatternRelativeToIgnoreFile:
  eslint:ignored-paths   original = "lib/"
  eslint:ignored-paths   cooked   = "lib/" +0ms
  eslint:ignored-paths addPatternRelativeToIgnoreFile:
  eslint:ignored-paths   original = "!.eslintrc.js"
  eslint:ignored-paths   cooked   = "!.eslintrc.js" +0ms
  eslint:ignored-paths contains: +2ms
  eslint:ignored-paths   target = "/Users/simen/repos/eslint-plugin-jest/src/index.ts" +0ms
  eslint:ignored-paths   result = false +0ms
  eslint:ignored-paths contains: +0ms
  eslint:ignored-paths   target = "/Users/simen/repos/eslint-plugin-jest/src/index.ts" +0ms
  eslint:ignored-paths   result = false +0ms
  eslint:cli-engine Processing /Users/simen/repos/eslint-plugin-jest/src/index.ts +0ms
  eslint:cli-engine Linting /Users/simen/repos/eslint-plugin-jest/src/index.ts +1ms
  eslint:config Constructing config file hierarchy for /Users/simen/repos/eslint-plugin-jest/src +0ms
  eslint:config Using .eslintrc and package.json files +0ms
  eslint:config Loading /Users/simen/repos/eslint-plugin-jest/.eslintrc.js +1ms
  eslint:config-file Loading JS config file: /Users/simen/repos/eslint-plugin-jest/.eslintrc.js +0ms
  eslint:plugins Loaded plugin eslint-config (eslint-plugin-eslint-config@1.0.4) (from /Users/simen/repos/eslint-plugin-jest/node_modules/eslint-plugin-eslint-config/lib/index.js) +0ms
  eslint:plugins Loaded plugin eslint-plugin (eslint-plugin-eslint-plugin@2.3.0) (from /Users/simen/repos/eslint-plugin-jest/node_modules/eslint-plugin-eslint-plugin/lib/index.js) +8ms
  eslint:plugins Loaded plugin eslint-comments (eslint-plugin-eslint-comments@3.2.0) (from /Users/simen/repos/eslint-plugin-jest/node_modules/eslint-plugin-eslint-comments/index.js) +8ms
  eslint:plugins Loaded plugin node (eslint-plugin-node@11.1.0) (from /Users/simen/repos/eslint-plugin-jest/node_modules/eslint-plugin-node/lib/index.js) +67ms
  eslint:plugins Loaded plugin prettier (eslint-plugin-prettier@3.3.0) (from /Users/simen/repos/eslint-plugin-jest/node_modules/eslint-plugin-prettier/eslint-plugin-prettier.js) +2ms
  eslint:plugins Loaded plugin import (eslint-plugin-import@2.22.1) (from /Users/simen/repos/eslint-plugin-jest/node_modules/eslint-plugin-import/lib/index.js) +78ms
Error: Cannot find module 'eslint/lib/rules/utils/ast-utils'
Require stack:
- /Users/simen/repos/eslint-plugin-jest/node_modules/@typescript-eslint/eslint-plugin/dist/rules/no-unused-vars.js
- /Users/simen/repos/eslint-plugin-jest/node_modules/@typescript-eslint/eslint-plugin/dist/rules/index.js
- /Users/simen/repos/eslint-plugin-jest/node_modules/@typescript-eslint/eslint-plugin/dist/index.js
- /Users/simen/repos/eslint-plugin-jest/node_modules/eslint/lib/config/plugins.js
- /Users/simen/repos/eslint-plugin-jest/node_modules/eslint/lib/config.js
- /Users/simen/repos/eslint-plugin-jest/node_modules/eslint/lib/cli-engine.js
- /Users/simen/repos/eslint-plugin-jest/node_modules/eslint/lib/cli.js
- /Users/simen/repos/eslint-plugin-jest/node_modules/eslint/bin/eslint.js
    at Function.Module._resolveFilename (internal/modules/cjs/loader.js:880:15)
    at Function.Module._load (internal/modules/cjs/loader.js:725:27)
    at Module.require (internal/modules/cjs/loader.js:952:19)
    at require (internal/modules/cjs/helpers.js:88:18)
    at Object.<anonymous> (/Users/simen/repos/eslint-plugin-jest/node_modules/@typescript-eslint/eslint-plugin/dist/rules/no-unused-vars.js:24:21)
    at Module._compile (internal/modules/cjs/loader.js:1063:30)
    at Object.Module._extensions..js (internal/modules/cjs/loader.js:1092:10)
    at Module.load (internal/modules/cjs/loader.js:928:32)
    at Function.Module._load (internal/modules/cjs/loader.js:769:14)
    at Module.require (internal/modules/cjs/loader.js:952:19)

The regression was introduced in #2768.

Versions

package version
@typescript-eslint/eslint-plugin 4.10.0
@typescript-eslint/parser 4.10.0
TypeScript 4.1.3
ESLint 5.16.0
node 14.15.0

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't workingpackage: eslint-pluginIssues related to @typescript-eslint/eslint-plugin

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions