fix(eslint-plugin): support eslint@5 #2917
Conversation
|
Thanks for the PR, @SimenB! typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community. The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately. Thanks again! 🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint. As a thank you, your profile/company logo will be added to our main README which receives thousands of unique visitors per day. |
| @@ -46,6 +46,7 @@ | |||
| "@typescript-eslint/scope-manager": "4.12.0", | |||
| "debug": "^4.1.1", | |||
| "functional-red-black-tree": "^1.0.1", | |||
| "lodash": "^4.17.15", | |||
There was a problem hiding this comment.
@typescript-eslint/eslint-plugin-tslint and @typescript-eslint/typescript-estree already depend on it, so shouldn't make a difference
| : str || ''; | ||
| } | ||
|
|
||
| function getNameLocationInGlobalDirectiveComment( |
There was a problem hiding this comment.
my IDE "complained" about duplicate code, so I found this and just removed it
Codecov Report
@@ Coverage Diff @@
## master #2917 +/- ##
==========================================
+ Coverage 92.76% 92.77% +0.01%
==========================================
Files 311 311
Lines 10460 10456 -4
Branches 2957 2954 -3
==========================================
- Hits 9703 9701 -2
Misses 348 348
+ Partials 409 407 -2
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Fixes #2890