-
-
Notifications
You must be signed in to change notification settings - Fork 2.8k
Remove TSParenthesizedType
#3136
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove TSParenthesizedType
#3136
Comments
This is a legacy AST node that is leftover from the times that the parser didn't do too much smart stuff, and instead just converted any new TS nodes by prefixing their name with We could probably remove them now, as they only really complicate the AST. |
Just because I should have probably done this way back when, figured I'd close this loop now as we're making this change now. @nicolo-ribaudo - if you've got questions about the TS AST - don't hesitate to reach out to me somewhere (slack, github, twitter). A lot of the weirdness in the TS AST you guys generate is likely due to legacy things from when this project was spun up way back when - so I can probably answer your questions. It'd be good for us to keep in sync as well. |
fixes #3136 Co-authored-by: Brad Zacher <brad.zacher@gmail.com>
fixes #3136 Co-authored-by: Brad Zacher <brad.zacher@gmail.com>
fixes #3136 Co-authored-by: Brad Zacher <brad.zacher@gmail.com>
fixes #3136 Co-authored-by: Brad Zacher <brad.zacher@gmail.com>
fixes #3136 Co-authored-by: Brad Zacher <brad.zacher@gmail.com>
The parser currently generates
TSParenthesizedType
nodes, which are totally redundant as far as I know.Or am I missing something and they're actually used somehow?
Did you consider removing them or probably hiding behind a flag?
Related issue in Babel: babel/babel#9546
The text was updated successfully, but these errors were encountered: