Skip to content

[no-duplicate-imports] deprecate rule in favour of import/no-duplicates #4238

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
bradzacher opened this issue Nov 30, 2021 · 0 comments · Fixed by #4973
Closed

[no-duplicate-imports] deprecate rule in favour of import/no-duplicates #4238

bradzacher opened this issue Nov 30, 2021 · 0 comments · Fixed by #4973
Labels
accepting prs Go ahead, send a pull request that resolves this issue breaking change This change will require a new major version to be released package: eslint-plugin Issues related to @typescript-eslint/eslint-plugin

Comments

@bradzacher
Copy link
Member

Separating out from #4225 (comment)

In #2609 we added an extension rule for the core no-duplicate-imports. In hindsight - this wasn't a great idea because there already exists an even better rule in the ecosystem - import/no-duplicates.

Instead of us attempting to maintain a competing rule we should instead deprecated our version of the rule and point users at the eslint-plugin-import rule instead.

Similar to camelcase - we can maintain a markdown doc which points users to the better rule.
@bradzacher bradzacher added package: eslint-plugin Issues related to @typescript-eslint/eslint-plugin breaking change This change will require a new major version to be released RFC labels Nov 30, 2021
@bradzacher bradzacher added this to the 6.0.0 milestone Nov 30, 2021
This was referenced Dec 21, 2021
Merged
Closed
@bradzacher bradzacher mentioned this issue Jan 20, 2022
Closed
@JoshuaKGoldberg JoshuaKGoldberg added the accepting prs Go ahead, send a pull request that resolves this issue label Feb 24, 2022
@snewcomer snewcomer mentioned this issue May 14, 2022
Merged
3 tasks
@Hazmi35 Hazmi35 mentioned this issue Jun 4, 2022
Closed
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 16, 2022
@JoshuaKGoldberg JoshuaKGoldberg removed this from the 6.0.0 milestone Feb 22, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
accepting prs Go ahead, send a pull request that resolves this issue breaking change This change will require a new major version to be released package: eslint-plugin Issues related to @typescript-eslint/eslint-plugin
Projects
None yet
Milestone
No milestone
2 participants
@JoshuaKGoldberg @bradzacher