Skip to content

Repo: simplify prettier include lists #5060

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
JoshuaKGoldberg opened this issue May 23, 2022 · 1 comment · Fixed by #5380
Closed

Repo: simplify prettier include lists #5060

JoshuaKGoldberg opened this issue May 23, 2022 · 1 comment · Fixed by #5380
Labels
accepting prs Go ahead, send a pull request that resolves this issue repo maintenance things to do with maintenance of the repo, and not with code/docs

Comments

@JoshuaKGoldberg
Copy link
Member

Overview

Copying conversation from https://github.com/typescript-eslint/typescript-eslint/pull/5027/files#r878861604: we explicitly list file extensions for Prettier. It's getting a little unweildy.

    "format": "prettier --write \"./**/*.{ts,mts,cts,tsx,js,mjs,cjs,jsx,json,md,css}\" --ignore-path ../../.prettierignore",

Let's look at using @Josh-Cena's suggestion of prettier --write \"./**/*\" --ignore-unknown --ignore-path ....

It would be nice to format all supported files, including yaml...
@JoshuaKGoldberg JoshuaKGoldberg added repo maintenance things to do with maintenance of the repo, and not with code/docs accepting prs Go ahead, send a pull request that resolves this issue labels May 23, 2022
This was referenced May 23, 2022
Closed
Merged
@lydell
Copy link
Contributor

lydell commented Jun 6, 2022

ℹ️ You shouldn’t need a glob at all, prettier --write . --whatever should do the trick. That’s the recommended way of using Prettier: https://prettier.io/docs/en/install.html and https://prettier.io/docs/en/install.html#summary

@JoshuaKGoldberg JoshuaKGoldberg mentioned this issue Jun 19, 2022
Closed
@JoshuaKGoldberg JoshuaKGoldberg mentioned this issue Jul 25, 2022
Merged
3 tasks
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 7, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
accepting prs Go ahead, send a pull request that resolves this issue repo maintenance things to do with maintenance of the repo, and not with code/docs
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore: simplify prettier include lists JoshuaKGoldberg/typescript-eslint
2 participants
@lydell @JoshuaKGoldberg