Skip to content

Docs: Add a saved reply for denying formatting rule suggestions #5111

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
JoshuaKGoldberg opened this issue May 30, 2022 · 3 comments
Closed
Labels
accepting prs Go ahead, send a pull request that resolves this issue locked due to age Please open a new issue if you'd like to say more. See https://typescript-eslint.io/contributing. repo maintenance things to do with maintenance of the repo, and not with code/docs

Comments

@JoshuaKGoldberg
Copy link
Member

Suggestion

Following #4907: we very much do not want to be spending time on formatting rules. And while it would be nice to prosthelytize in issues that ask for formatting work, we certainly don't want to repeatedly get into heated discussions.

Suggestion: how about we add a GitHub Actions bot that adds an automatic comment to issues? It should explicitly say that it is an automated bot that does not need to be responded to. Something like:

Beep boop, hello! 🤖 I'm the TypeScript ESLint Formatting Bot, and I'm popping in automatically to advertise that we strongly recommend against using ESLint rules for formatting purposes.

This message is automated and serves only as a reminder. We will still triage your issue and, as long as it only involves fixing existing formatting rules, do not plan on automatically closing it.
Please do not respond to this message. Thanks! 💝

Ideally it should only post at most once per issue...

@JoshuaKGoldberg JoshuaKGoldberg added triage Waiting for team members to take a look repo maintenance things to do with maintenance of the repo, and not with code/docs labels May 30, 2022
@JoshuaKGoldberg JoshuaKGoldberg added accepting prs Go ahead, send a pull request that resolves this issue and removed triage Waiting for team members to take a look labels Jun 25, 2022
@Josh-Cena
Copy link
Member

@JoshuaKGoldberg: what do you think should be done now? Auto-close them? Just use a saved reply instead?

@JoshuaKGoldberg
Copy link
Member Author

Ha! I'd forgotten about this issue. Yeah, I don't think we need to invest in dev tooling. Just adding a saved reply sounds reasonable to me.

@JoshuaKGoldberg JoshuaKGoldberg changed the title Repo: Consider adding a bot that warns against using ESLint for formatting purposes Docs: Add a saved reply for denying formatting rule suggestions Dec 18, 2023
@JoshuaKGoldberg
Copy link
Member Author

We haven't had to do this in 2024 yet. Looks like this aged away. Yay!

@JoshuaKGoldberg JoshuaKGoldberg closed this as not planned Won't fix, can't repro, duplicate, stale Jun 1, 2024
@github-actions github-actions bot added the locked due to age Please open a new issue if you'd like to say more. See https://typescript-eslint.io/contributing. label Jun 9, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 9, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
accepting prs Go ahead, send a pull request that resolves this issue locked due to age Please open a new issue if you'd like to say more. See https://typescript-eslint.io/contributing. repo maintenance things to do with maintenance of the repo, and not with code/docs
Projects
None yet
Development

No branches or pull requests

2 participants