Skip to content

TypeScript 4.8 Support #5227

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
bradzacher opened this issue Jun 21, 2022 · 9 comments · Fixed by #5551
Closed

TypeScript 4.8 Support #5227

bradzacher opened this issue Jun 21, 2022 · 9 comments · Fixed by #5551
Assignees
@bradzacher
Labels
accepting prs Go ahead, send a pull request that resolves this issue AST PRs and Issues about the AST structure dependencies Issue about dependencies of the package New TypeScript Version

Comments

@bradzacher
Copy link
Member

bradzacher commented Jun 21, 2022 •
edited
Loading

https://devblogs.microsoft.com/typescript/announcing-typescript-4-8-rc/

This issue is just to track all of the new features and their implementation state in this project.
As with all releases, we will not necessarily to support all features until closer to the full release when everything the features are stabilised.

Please be patient.

🔲 lib.d.ts Updates (no PR)

We will need to regenerate our types within scope-manager.

Other changes with no impact to us

  • Improved Intersection Reduction, Union Compatibility, and Narrowing
  • Improved Inference for infer Types in Template String Types
  • --build, --watch, and --incremental Performance Improvements
  • Errors When Comparing Object and Array Literals
  • Improved Inference from Binding Patterns
  • File-Watching Fixes (Especially Across git checkouts)
  • Find-All-References Performance Improvements
  • Exclude Specific Files from Auto-Imports
  • Breaking Changes:
    • Unconstrained Generics No Longer Assignable to {}
    • Types Cannot Be Imported/Exported in JavaScript Files
    • Binding Patterns Do Not Directly Contribute to Inference Candidates
@bradzacher bradzacher added dependencies Issue about dependencies of the package AST PRs and Issues about the AST structure labels Jun 21, 2022
@bradzacher bradzacher pinned this issue Jun 21, 2022
@paralin

This comment was marked as off-topic.

Sign in to view
@paralin paralin mentioned this issue Jun 22, 2022
Closed
@bradzacher

This comment was marked as off-topic.

Sign in to view
@paralin

This comment was marked as off-topic.

Sign in to view
@bradzacher
Copy link
Member Author

There is an unlisted breaking change in this TS version - the AST has been changed in a number of places - microsoft/TypeScript#49089.

Unfortunately the TS team decided to never set the affected properties whilst keeping them on the types and marking them as @deprecated.
We'll need to manually audit all of the changes listed in this file against our codebase to look for any new breakages.
Likely some of the breakages should be flagged by our tests, but it's a shame that we'll have to audit the code to find the places to fix.

@bradzacher bradzacher mentioned this issue Aug 17, 2022
Closed
4 tasks
@eamodio
Copy link

eamodio commented Aug 22, 2022

Would something like this: https://github.com/gund/eslint-plugin-deprecation help?

@bradzacher
Copy link
Member Author

@eamodio that would definitely help us identify these properties - though it'll likely have other noise. But it'll be better than nothing!

@Chris7ca Chris7ca mentioned this issue Aug 26, 2022
Closed
4 tasks
@bradzacher
Copy link
Member Author

TS 4.8 has officially released today.
https://devblogs.microsoft.com/typescript/announcing-typescript-4-8/

@bradzacher bradzacher added the accepting prs Go ahead, send a pull request that resolves this issue label Aug 26, 2022
@rearl
Copy link

rearl commented Aug 26, 2022

When will typescript-eslint support TS 4.8?

@bradzacher bradzacher self-assigned this Aug 26, 2022
@bradzacher
Copy link
Member Author

When it's ready, @rearl!

@bradzacher bradzacher mentioned this issue Aug 26, 2022
Merged
3 tasks
@TGCrystal TGCrystal mentioned this issue Aug 26, 2022
Merged
@dargmuesli dargmuesli mentioned this issue Aug 26, 2022
Merged
1 task
@tobiasdiez tobiasdiez mentioned this issue Aug 27, 2022
Merged
duckies added a commit to duckies/eslint-config that referenced this issue Aug 27, 2022
@duckies
fix: downgrade TypeScript
5c4460b 
Related: typescript-eslint/typescript-eslint#5227
@RobinTail RobinTail mentioned this issue Aug 27, 2022
Merged
@fisker fisker mentioned this issue Aug 28, 2022
Merged
1 task
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 29, 2022
@bradzacher bradzacher unpinned this issue Oct 2, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@bradzacher bradzacher

Labels
accepting prs Go ahead, send a pull request that resolves this issue AST PRs and Issues about the AST structure dependencies Issue about dependencies of the package New TypeScript Version
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: support TypeScript 4.8 typescript-eslint/typescript-eslint
4 participants
@paralin @eamodio @bradzacher @rearl