Skip to content

Repo: Migrate json-schema from deprecated $definitions to $defs  #5509

Closed
@JoshuaKGoldberg

Description

@JoshuaKGoldberg

Suggestion

From bcherny/json-schema-to-typescript#470 (comment):

Hey! $definitions isn't a valid JSON-schema keyword. You want definitions (legacy) or $defs (preferred).

See https://json-schema.org/draft/2019-09/release-notes.html#semi-incompatible-changes

Tracking being more aggressive about warning about invalid keywords in bcherny/json-schema-to-typescript#471

Related and hopefully will be fixed by this work: TIL if you yarn jest explicit-member within packages/eslint-plugin, a whole bunch of this spam gets logged to the console:

  console.warn
    can't resolve reference #/definitions/accessibilityLevel from id #

      at Object.generate_ref [as code] (../../node_modules/ajv/lib/dotjs/ref.js:57:19)
      at Object.generate_validate [as validate] (../../node_modules/ajv/lib/dotjs/validate.js:277:37)
      at Object.generate_properties [as code] (../../node_modules/ajv/lib/dotjs/properties.js:201:26)
      at Object.generate_validate [as validate] (../../node_modules/ajv/lib/dotjs/validate.js:374:35)
      at Object.generate_items [as code] (../../node_modules/ajv/lib/dotjs/items.js:77:26)
      at generate_validate (../../node_modules/ajv/lib/dotjs/validate.js:374:35)
      at localCompile (../../node_modules/ajv/lib/compile/index.js:88:22)

This is likely a result of #5386. It doesn't seem to be breaking anything, but it probably should...?

Metadata

Metadata

Assignees

No one assigned

    Labels

    repo maintenancethings to do with maintenance of the repo, and not with code/docstriageWaiting for team members to take a look

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions