Skip to content

Refactor: replace module-scoped code and extra variables #5833

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
JoshuaKGoldberg opened this issue Oct 16, 2022 · 0 comments · Fixed by #5834
Closed

Refactor: replace module-scoped code and extra variables #5833

JoshuaKGoldberg opened this issue Oct 16, 2022 · 0 comments · Fixed by #5834
Assignees
@JoshuaKGoldberg
Labels
accepting prs Go ahead, send a pull request that resolves this issue package: parser Issues related to @typescript-eslint/parser package: typescript-estree Issues related to @typescript-eslint/typescript-estree repo maintenance things to do with maintenance of the repo, and not with code/docs

Comments

@JoshuaKGoldberg
Copy link
Member

JoshuaKGoldberg commented Oct 16, 2022 •
edited
Loading

Suggestion

parseAndGenerateServices is called inside parseForESLint from @typescript-eslint/typescript-estree. This code is old and has been added to a lot - ripe for refactors! For example, the code and extra module-scoped variables are from an older code style that hasn’t been adhered to in a long while.

This issue is from a pairing with @bradzacher
@JoshuaKGoldberg JoshuaKGoldberg added triage Waiting for team members to take a look repo maintenance things to do with maintenance of the repo, and not with code/docs labels Oct 16, 2022
@JoshuaKGoldberg JoshuaKGoldberg self-assigned this Oct 16, 2022
@JoshuaKGoldberg JoshuaKGoldberg added package: parser Issues related to @typescript-eslint/parser package: typescript-estree Issues related to @typescript-eslint/typescript-estree accepting prs Go ahead, send a pull request that resolves this issue and removed triage Waiting for team members to take a look labels Oct 16, 2022
@JoshuaKGoldberg JoshuaKGoldberg mentioned this issue Oct 16, 2022
Merged
3 tasks
@JoshuaKGoldberg JoshuaKGoldberg mentioned this issue Oct 26, 2022
Closed
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 17, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@JoshuaKGoldberg JoshuaKGoldberg

Labels
accepting prs Go ahead, send a pull request that resolves this issue package: parser Issues related to @typescript-eslint/parser package: typescript-estree Issues related to @typescript-eslint/typescript-estree repo maintenance things to do with maintenance of the repo, and not with code/docs
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore: document and refactor 'extra' to 'parserSettings' JoshuaKGoldberg/typescript-eslint
1 participant
@JoshuaKGoldberg