Skip to content

Bug: [class-literal-property-style] A literal getter with a setter does not pass lint, and incorrectly auto-fix #5961

Closed
@sviat9440

Description

@sviat9440

Before You File a Bug Report Please Confirm You Have Done The Following...

  • I have tried restarting my IDE and the issue persists.
  • I have updated to the latest version of the packages.
  • I have searched for related issues and found none that matched my issue.
  • I have read the FAQ and my problem is not listed.

Playground Link

https://typescript-eslint.io/play/#ts=4.8.4&sourceType=module&code=MYGwhgzhAEAqCmEAu0DeBYAUNaF4oDcwQBXeACiJAC5ckAnASwDsBzASjSxxwHpfoAOmHdoAXyyjW+aFTLl2tZEzZdsPevhL1m0AORJESPQG5REzGKA&eslintrc=N4KABGBEBOCuA2BTAzpAXGUEKQAIBcBPABxQGNoBLY-AWhXkoDt8B6M+AQ2WVsf0TRO8WsWgB7UtCK1kRJOiiCJ0SODABfEBqA&tsconfig=N4KABGBEDGD2C2AHAlgGwKYCcDyiAuysAdgM6QBcYoEEkJemy0eAcgK6qoDCAFutAGsylBm3QAacDUjoAHoizJ46IngCGqACL9YmNXl3Cwo9FIC+IM0A

Repro Code

class Test {
  set value(val: string) {
    // ...
  }

  get value(): string {
    return 'test';
  }
}

ESLint Config

module.exports = {
  "rules": {
    "@typescript-eslint/class-literal-property-style": "error"
  }
}

tsconfig

{
  "compilerOptions": {
    "strictNullChecks": true,
    "experimentalDecorators": true
  }
}

Expected Result

Should be no errors because the setter exists

Actual Result

Error: Literals should be exposed using readonly fields.

Auto-fix:

class Test {
  set value(val: string) {
    // ...
  }

  readonly value = 'test';
}

Then TypeScript error:
Duplicate identifier 'value'

Additional Info

No response

Versions

package version
@typescript-eslint/eslint-plugin 5.42.1
@typescript-eslint/parser 5.42.1
TypeScript 4.8.4
ESLint 8.15.0
node web

Metadata

Metadata

Assignees

No one assigned

    Labels

    accepting prsGo ahead, send a pull request that resolves this issuebugSomething isn't workingpackage: eslint-pluginIssues related to @typescript-eslint/eslint-plugin

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions