Skip to content

Repo: Automatically remove 'awaiting response' label when PR review is requested #6033

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
JoshuaKGoldberg opened this issue Nov 19, 2022 · 0 comments · Fixed by #7416
Closed

Repo: Automatically remove 'awaiting response' label when PR review is requested #6033

JoshuaKGoldberg opened this issue Nov 19, 2022 · 0 comments · Fixed by #7416
Assignees
@JoshuaKGoldberg
Labels
accepting prs Go ahead, send a pull request that resolves this issue repo maintenance things to do with maintenance of the repo, and not with code/docs

Comments

@JoshuaKGoldberg
Copy link
Member

Suggestion

I've noticed that the following will happen:

  1. A PR is sent or updated
  2. A review requests changes and the awaiting response label is added
  3. The author addresses changes and re-requests review
  4. Some time passes
  5. Another review comes in

During 4. Some time passes, the awaiting response label is still on the PR - even though it's waiting for us to review it!

Proposal: let's add a repo automation that removes the awaiting response label from a PR when a review is requested on it? I think requesting a review generally implies a code response has been pushed.
@JoshuaKGoldberg JoshuaKGoldberg added triage Waiting for team members to take a look repo maintenance things to do with maintenance of the repo, and not with code/docs labels Nov 19, 2022
@JoshuaKGoldberg JoshuaKGoldberg added accepting prs Go ahead, send a pull request that resolves this issue and removed triage Waiting for team members to take a look labels Dec 16, 2022
@JoshuaKGoldberg JoshuaKGoldberg mentioned this issue Mar 13, 2023
Merged
3 tasks
@JoshuaKGoldberg JoshuaKGoldberg self-assigned this Mar 13, 2023
@JoshuaKGoldberg JoshuaKGoldberg mentioned this issue Aug 5, 2023
Merged
3 tasks
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 18, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@JoshuaKGoldberg JoshuaKGoldberg

Labels
accepting prs Go ahead, send a pull request that resolves this issue repo maintenance things to do with maintenance of the repo, and not with code/docs
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore: add pr-review-requested.yml workflow JoshuaKGoldberg/typescript-eslint
1 participant
@JoshuaKGoldberg