Skip to content

eslint-plugin-tslint is unexpectedly linting .js* files #615

Closed
@joeyj-msft

Description

@joeyj-msft

I started seeing linebreak-style linting failures when trying this plugin. I then realized that these were only happening for .js* files which I dont have configured in tslint.config.

tslint command (works as expected)

tslint -p .

eslint command

eslint . --ext .js,.jsx,.ts,.tsx

tslint.json (simplified)

{
  "defaultSeverity": "error",
  "extends": [
    "tslint:all"
  ],
  "rules": {
    "linebreak-style": false
  }
}

.eslintrc.json (simplified)

{
  "plugins": [
    "@typescript-eslint/tslint"
  ],
  "parser": "@typescript-eslint/parser",
  "parserOptions": {
    "project": "./tsconfig.json"
  },
  "rules": {
    "linebreak-style": [ "error", "windows" ],
    "@typescript-eslint/tslint/config": [ "error", {
      "lintFile": "./tslint.json"
    }]
  },
  "settings": {
    "react": {
      "version": "detect"
    }
  }
}

tsconfig.json

{
  "compileOnSave": false,
  "compilerOptions": {
    "allowSyntheticDefaultImports": true,
    "baseUrl": ".",
    "downlevelIteration": true,
    "emitDecoratorMetadata": true,
    "esModuleInterop": true,
    "experimentalDecorators": true,
    "forceConsistentCasingInFileNames": true,
    "jsx": "react",
    "lib": ["es6", "dom"],
    "module": "es2015",
    "moduleResolution": "node",
    "noUnusedLocals": true,
    "noUnusedParameters": true,
    "outDir": "dist",
    "paths": {
      "office-ui-fabric-react": ["node_modules/office-ui-fabric-react/lib-commonjs"],
      "msal": ["node_modules/msal/lib-commonjs"]
    },
    "plugins": [],
    "skipLibCheck": true,
    "sourceMap": true,
    "strict": true,
    "target": "es5"
  },
  "include": [
    "src"
  ]
}

What did you expect to happen?
I'd expect .js* files to not be linted with tslint.

What actually happened?
.js* files are being linted with tslint.

Versions

package version
@typescript-eslint/eslint-plugin-tslint 1.10.2
@typescript-eslint/parser 1.10.2
TypeScript 3.5.2
ESLint 5.16.0
node 10.15.3
npm 6.9.0

Metadata

Metadata

Assignees

No one assigned

    Labels

    documentationDocumentation ("docs") that needs adding/updatingpackage: eslint-plugin-tslintIssues related to @typescript-eslint/eslint-plugin-tslint

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions