-
-
Notifications
You must be signed in to change notification settings - Fork 2.8k
Rule parity with TSLint core #62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
@JoshuaKGoldberg I've been working through some of these in the process of trying to get the TypeScript repo onto ESLint. I have PRs up for a few and a few I'm still working out the details on, but I'd love some help with the rest, since I'm prioritizing the ones that TS has enabled. |
I'm not at all familiar with the TSLint rule API, but would it be feasible to have a compatibility wrapper that generically converts TSLint rules to ESLint rules at runtime? That would avoid the effort of manually reimplementing TSLint rules as ESLint rules, both for this project and for custom rules. In other words, it would be similar to |
@not-an-aardvark We now reuse the ts SourceFile and Program via |
Definitely excited to explore more ideas around bridging/conversion though! Just wanted to point that out :) |
I see, I was confused because it's passing in the source text too, but I hadn't realized it was also passing in the parsed version. |
You might well be right, I need to look into - thanks for following up! |
@JoshuaKGoldberg Just to confirm, PRs definitely welcome! I think it would be good to use the existing ROADMAP.md as the source of truth for the progress of this, rather than the items in this issue, as it is more discoverable and under version control. Thanks! |
Will/can rules that depend on compiler information be implemented in this bridge as well (e.g. the helpful |
@fabb here's a list of currently implemented rules that already use the parser services to do get type information. |
Spinning off of bradzacher/eslint-plugin-typescript#276: I'm a TSLint maintainer and would love to help get all the TSLint-exclusive rules available in ESLint. For each of these, would you accept a PR adding them in?
See the roadmap for an up-to-date listing
The text was updated successfully, but these errors were encountered: