Skip to content

Enhancement: [await-thenable] Add a suggestion fixer #6235

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
4 tasks done
JoshuaKGoldberg opened this issue Dec 17, 2022 · 0 comments · Fixed by #7437
Closed
4 tasks done

Enhancement: [await-thenable] Add a suggestion fixer #6235

JoshuaKGoldberg opened this issue Dec 17, 2022 · 0 comments · Fixed by #7437
Assignees
@JoshuaKGoldberg
Labels
accepting prs Go ahead, send a pull request that resolves this issue enhancement: plugin rule option New rule option for an existing eslint-plugin rule package: eslint-plugin Issues related to @typescript-eslint/eslint-plugin

Comments

@JoshuaKGoldberg
Copy link
Member

Before You File a Proposal Please Confirm You Have Done The Following...

My proposal is suitable for this project

  • I believe my proposal would be useful to the broader TypeScript community (meaning it is not a niche proposal).

Link to the rule's documentation

https://typescript-eslint.io/rules/await-thenable/

Description

We can't add a fixer to the rule's reports because removing a seemingly unnecessary await potentially changes program runtime. But we can suggest to the user to remove the await. https://eslint.org/docs/latest/developer-guide/working-with-rules#providing-suggestions

Fail

await "";

Pass

"";

Additional Info

No response
@JoshuaKGoldberg JoshuaKGoldberg added package: eslint-plugin Issues related to @typescript-eslint/eslint-plugin enhancement: plugin rule option New rule option for an existing eslint-plugin rule accepting prs Go ahead, send a pull request that resolves this issue labels Dec 17, 2022
@JoshuaKGoldberg JoshuaKGoldberg self-assigned this Aug 7, 2023
@JoshuaKGoldberg JoshuaKGoldberg mentioned this issue Aug 7, 2023
Merged
3 tasks
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 16, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@JoshuaKGoldberg JoshuaKGoldberg

Labels
accepting prs Go ahead, send a pull request that resolves this issue enhancement: plugin rule option New rule option for an existing eslint-plugin rule package: eslint-plugin Issues related to @typescript-eslint/eslint-plugin
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(eslint-plugin): [await-thenable] added suggestion fixer JoshuaKGoldberg/typescript-eslint
1 participant
@JoshuaKGoldberg