Skip to content

[indent] error indent at template types #658

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
lext-7 opened this issue Jun 28, 2019 · 4 comments
Closed

[indent] error indent at template types #658

lext-7 opened this issue Jun 28, 2019 · 4 comments
Labels
bug Something isn't working duplicate This issue or pull request already exists package: eslint-plugin Issues related to @typescript-eslint/eslint-plugin
Milestone
indent rewrite

Comments

@lext-7
Copy link

lext-7 commented Jun 28, 2019

Repro

{
  "rules": {
    "@typescript-eslint/indent": "error"
  }
}
readonly requestFn: IApiPagingCrawlMixinOptions<
    TUserData,
    TResponse
>['requestFn'];

Expected Result

It will raise indent error:

readonly requestFn: IApiPagingCrawlMixinOptions<
    TUserData,
    TResponse
>['requestFn'];

Actual Result

readonly requestFn: IApiPagingCrawlMixinOptions<
TUserData,
TResponse
>['requestFn'];

Additional Info

Versions

package version
@typescript-eslint/eslint-plugin 1.11.0"
@typescript-eslint/parser 1.11.0"
TypeScript 3.5.2
ESLint 6.0.1
node 12.2.0
npm 6.9.0
@lext-7 lext-7 added package: eslint-plugin Issues related to @typescript-eslint/eslint-plugin triage Waiting for team members to take a look labels Jun 28, 2019
@bradzacher bradzacher added bug Something isn't working and removed triage Waiting for team members to take a look labels Jun 28, 2019
@bradzacher bradzacher added this to the indent rewrite milestone Jun 28, 2019
@lext-7
Copy link
Author

lext-7 commented Jul 11, 2019

When will it be fixed ? Is there a promised time ?

@bradzacher
Copy link
Member

If you need it sooner rather than later, then feel free to raise a PR - we encourage and appreciate all contributions.

Otherwise a rewrite of the indent rule is on the cards, but it's a very, very complex rule and will take a long while.
I don't have the time to dedicate to figuring out the eslint base code and extending it with typescript nodes, so right now it's on the backlog.

@j3bb9z
Copy link

j3bb9z commented Dec 3, 2019

I think this is the same issue: #455

@bradzacher
Copy link
Member

it is actually, thanks for pointing that out.

@bradzacher bradzacher added the duplicate This issue or pull request already exists label Dec 3, 2019
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 20, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
bug Something isn't working duplicate This issue or pull request already exists package: eslint-plugin Issues related to @typescript-eslint/eslint-plugin
Projects
None yet
Milestone
indent rewrite
Development

No branches or pull requests
3 participants
@j3bb9z @lext-7 @bradzacher