Skip to content

Repo: v6 canary releases workflow is failing #7111

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
JoshuaKGoldberg opened this issue Jun 16, 2023 · 4 comments
Closed

Repo: v6 canary releases workflow is failing #7111

JoshuaKGoldberg opened this issue Jun 16, 2023 · 4 comments
Assignees
@JamesHenry
Labels
repo maintenance things to do with maintenance of the repo, and not with code/docs triage Waiting for team members to take a look

Comments

@JoshuaKGoldberg
Copy link
Member

Suggestion

From the v6 canary publish builds (example: https://github.com/typescript-eslint/typescript-eslint/actions/runs/5291845795/jobs/9578445226?pr=5886):

lerna verb publish @typescript-eslint/rule-tester
lerna ERR! EUSAGE Can't generate provenance for new or private package, you must set `access` to public.

Guessing this is from @typescript-eslint/rule-tester being newly added in v6.

My default behavior would be to set "publishConfig": { "access": "public" } in all public facing package.jsons. But @JamesHenry I'll defer to you as the Nx expert, is that the right thing to do?
@JoshuaKGoldberg JoshuaKGoldberg added triage Waiting for team members to take a look repo maintenance things to do with maintenance of the repo, and not with code/docs labels Jun 16, 2023
@JoshuaKGoldberg
Copy link
Member Author

Now that #7110 is merged I really want the v6 canaries to be publishing 😅 trying out b411706...

@JamesHenry
Copy link
Member

@JoshuaKGoldberg cool let me know if that doesn’t work, I’m available now

@JamesHenry
Copy link
Member

Looks like it worked fine! FWIW I believe this is is just default npm behaviour, even when manually publishing I always need to specify —access public when publishing a new package for the first time

@JoshuaKGoldberg
Copy link
Member Author

Thinking out loud: it would be nice if lerna publish had an --access flag so we didn't need to specify it in the package.json manually each time...

@JoshuaKGoldberg JoshuaKGoldberg mentioned this issue Jun 18, 2023
Closed
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 26, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@JamesHenry JamesHenry

Labels
repo maintenance things to do with maintenance of the repo, and not with code/docs triage Waiting for team members to take a look
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@JamesHenry @JoshuaKGoldberg