Skip to content

Enhancement: [prefer-nullish-coalescing] Allow ignorePrimitives option to be true #7180

Closed
@JoshuaKGoldberg

Description

@JoshuaKGoldberg

Before You File a Proposal Please Confirm You Have Done The Following...

My proposal is suitable for this project

  • I believe my proposal would be useful to the broader TypeScript community (meaning it is not a niche proposal).

Link to the rule's documentation

https://typescript-eslint.io/rules/prefer-nullish-coalescing

Description

In #6487, @omril1 added a new ignorePrimitives option. Which is great! It lets us configure individually whether bigints, booleans, numbers, and/or strings, are ignored by the rule.

As a convenience, it'd be nice to allow the option to be set as just the shorthand true - to set all of them as true.

"@typescript-eslint/prefer-nullish-coalescing": ["error", {
  ignorePrimitives: true,
}]

Fail

n/a (no change)

Pass

n/a (no change)

Additional Info

The label here is slightly inaccurate - it's not a new rule option, it's an augmentation to an existing option.

Metadata

Metadata

Assignees

No one assigned

    Labels

    accepting prsGo ahead, send a pull request that resolves this issueenhancement: plugin rule optionNew rule option for an existing eslint-plugin rulegood first issueGood for newcomerspackage: eslint-pluginIssues related to @typescript-eslint/eslint-plugin

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions