Skip to content

Incorrect parsing for contextual keyword is #749

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
mrm-rideos opened this issue Jul 24, 2019 · 0 comments · Fixed by #750
Closed

Incorrect parsing for contextual keyword is #749

mrm-rideos opened this issue Jul 24, 2019 · 0 comments · Fixed by #750
Labels
package: typescript-estree Issues related to @typescript-eslint/typescript-estree triage Waiting for team members to take a look

Comments

@mrm-rideos
Copy link
Contributor

This is the same issue as #678, credit to @svr93 for the description. It seems the is keyword needs to be added as part of that fix as well. I'll attempt a PR as well.

What code were you trying to parse?

import { Map, is } from 'immutable'

What did you expect to happen?
token type Identifier with value is

What actually happened?
token type Keyword with value is

Versions

package version
@typescript-eslint/typescript-estree 1.13.0
TypeScript 3.5.3
node 10.15.3
npm 6.4.1
@mrm-rideos mrm-rideos added package: typescript-estree Issues related to @typescript-eslint/typescript-estree triage Waiting for team members to take a look labels Jul 24, 2019
@mrm-rideos mrm-rideos mentioned this issue Jul 24, 2019
Merged
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 21, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
package: typescript-estree Issues related to @typescript-eslint/typescript-estree triage Waiting for team members to take a look
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(typescript-estree): fix is identifier token typed as Keyword mrm-rideos/typescript-eslint
1 participant
@mrm-rideos