Skip to content

Repo: Integration tests failing on main from latest ESLint #7890

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
JoshuaKGoldberg opened this issue Nov 8, 2023 · 1 comment · Fixed by #7891
Closed

Repo: Integration tests failing on main from latest ESLint #7890

JoshuaKGoldberg opened this issue Nov 8, 2023 · 1 comment · Fixed by #7891
Labels
accepting prs Go ahead, send a pull request that resolves this issue repo maintenance things to do with maintenance of the repo, and not with code/docs

Comments

@JoshuaKGoldberg
Copy link
Member

Suggestion

See 75c1288 > https://github.com/typescript-eslint/typescript-eslint/actions/runs/6774184010/job/18410868606 > Run integration tests as an example:

 FAIL  tests/vue-sfc.test.ts (42.521 s)
  ● vue-sfc › should lint successfully

 FAIL  tests/recommended-does-not-require-program.test.ts (10.326 s)
  ● recommended-does-not-require-program › should lint successfully

Snapshot Summary
 › 2 snapshots failed from 2 test suites. Inspect your code changes or re-run jest with `-u` to update them.
Test Suites: 2 failed, 4 passed, 6 total
Tests:       2 failed, 4 passed, 6 total
Snapshots:   2 failed, 4 passed, 6 total
Time:        102.14 s
@JoshuaKGoldberg JoshuaKGoldberg added triage Waiting for team members to take a look repo maintenance things to do with maintenance of the repo, and not with code/docs labels Nov 8, 2023
@JoshuaKGoldberg JoshuaKGoldberg mentioned this issue Nov 8, 2023
Merged
3 tasks
@bradzacher
Copy link
Member

The joys of testing the json output instead of the CLI output - we get little invisible changes like this!

Also we used a formatting rule cos it was easier to setup a simple repro for heh.

@bradzacher bradzacher added accepting prs Go ahead, send a pull request that resolves this issue and removed triage Waiting for team members to take a look labels Nov 8, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 16, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
accepting prs Go ahead, send a pull request that resolves this issue repo maintenance things to do with maintenance of the repo, and not with code/docs
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore: fix integration tests for ESLint formatting deprecations JoshuaKGoldberg/typescript-eslint
2 participants
@JoshuaKGoldberg @bradzacher